Skip to content

Add note to unregister BrowserWindowResizeListener #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

Add note to unregister BrowserWindowResizeListener #4335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion articles/flow/advanced/browser-access.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,24 @@
[source,java]
----
Page page = UI.getCurrent().getPage();
page.addBrowserWindowResizeListener(
var listener = page.addBrowserWindowResizeListener(
event -> Notification.show("Window width="
+ event.getWidth()
+ ", height=" + event.getHeight()));
----

[NOTE]
When using [classname]`BrowserWindowResizeListener` you need to unregister it in order to avoid memory leaks.

Check failure on line 116 in articles/flow/advanced/browser-access.adoc

View workflow job for this annotation

GitHub Actions / lint 

[vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'unregister'?

Raw Output:
{"message": "[Vale.Spelling] Did you really mean 'unregister'?", "location": {"path": "articles/flow/advanced/browser-access.adoc", "range": {"start": {"line": 116, "column": 65}}}, "severity": "ERROR"}

[source,java]
----
@Override
protected void onDetach(DetachEvent detachEvent) {
// Listener needs to be eventually removed in order to avoid resource leak
listener.remove();
super.onDetach(detachEvent);
}
----


[discussion-id]`0DF2CC14-4401-49E4-B97D-920CAFEAAF8D`
Loading