docs: Add JUnit5 examples for TestBench9 #1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
tomivirkki
reviewed
Nov 4, 2022
mshabarov
requested changes
Nov 4, 2022
There was a problem hiding this comment.
We also need to put a general note in the first chapter of end-to-end part that since Vaadin 24 both JUnit 4 and JUnit 5 test framework versions are supported. Here maybe https://vaadin.com/docs/latest/testing/end-to-end/#features
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov
approved these changes
Nov 7, 2022
|
There will be updates related to testbench update. |
jouni
reviewed
Nov 14, 2022
jouni
reviewed
Nov 14, 2022
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
mshabarov
approved these changes
Nov 15, 2022
vursen
reviewed
Nov 17, 2022
| You can also handle creation and destruction of the WebDriver manually when running on a hub if you don't want to use `ParallelTest` for one reason or another. | ||
| In this case, you should create a `RemoteWebdriver` with the correct hub URL and set suitable `DesiredCapabilities` on the driver. | ||
|
|
||
| ==== Notes for JUnit 5 | ||
| If your test class already creates `WebDriver` implementing `DriverSupplier` you can remove it in favor of automatic driver initialization by TestBench. |
There was a problem hiding this comment.
Suggested change
| If your test class already creates `WebDriver` implementing `DriverSupplier` you can remove it in favor of automatic driver initialization by TestBench. | |
| If your test class already creates `WebDriver` implementing `DriverSupplier`, you can remove it in favor of automatic driver initialization by TestBench. |
There was a problem hiding this comment.
I've omitted that one and cannot apply it now :-/
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
russelljtdyer
added
Language checked
This reverts commit ffd14f0.
|
Actually, I’ll move Russell’s edits to another branch, so this PR stays focused on the original scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JUnit5 examples to present new features of Testbench 9 that will be available with Vaadin 24.
Fixes #1848