(ci) Updated testing to Node versions 18, 20 and 22

vHeemstra · Aug 10, 2024 · c56624f · c56624f
1 parent c74f876
commit c56624f
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 30 deletions.
diff --git a/.github/workflows/manual_bump_version.yml b/.github/workflows/manual_bump_version.yml
@@ -22,16 +22,16 @@ jobs:
         shell: bash
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
           fetch-depth: 0
           token: ${{ secrets.GH_TOKEN }}
 
       - name: Install Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@4
         with:
-          node-version: 16.x
+          node-version: 22.x
           registry-url: https://registry.npmjs.org/
 
       - name: Set Git user

diff --git a/.github/workflows/manual_run_test.yml b/.github/workflows/manual_run_test.yml
@@ -6,14 +6,14 @@ on:
       node_versions:
         description: 'Select Node versions'
         required: true
-        default: '["14.x", "16.x", "18.x"]'
+        default: '["18.x", "20.x", "22.x"]'
         type: choice
         options:
-          - '["14.x"]'
-          - '["16.x"]'
           - '["18.x"]'
-          - '["16.x", "18.x"]'
-          - '["14.x", "16.x", "18.x"]'
+          - '["20.x"]'
+          - '["22.x"]'
+          - '["20.x", "22.x"]'
+          - '["18.x", "20.x", "22.x"]'
       os_version:
         description: 'Select OS'
         required: true
@@ -39,11 +39,11 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
       - name: Install Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm install

diff --git a/.github/workflows/publish_on_release.yml b/.github/workflows/publish_on_release.yml
@@ -11,15 +11,15 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [18.x, 20.x, 22.x]
     runs-on: ${{ matrix.os }}
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
       - name: Install Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           # cache: 'npm'
@@ -34,13 +34,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
       - name: Install Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 22.x
           # cache: 'npm'
           registry-url: 'https://registry.npmjs.org'
       - run: npm install

diff --git a/.github/workflows/release_on_version_push.yml b/.github/workflows/release_on_version_push.yml
@@ -12,18 +12,18 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [18.x, 20.x, 22.x]
     runs-on: ${{ matrix.os }}
     defaults:
       run:
         shell: bash
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
       - name: Install Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm install
@@ -42,7 +42,7 @@ jobs:
           s=':white_check_mark: '"Node ${{ matrix.node-version }}"
           echo "$s" > ${{ env.FILENAME_TXT }}
       - name: Upload artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ env.FILENAME }}
           path: ${{ env.FILENAME_TXT }}
@@ -58,15 +58,15 @@ jobs:
       GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
     steps:
       - name: Check out repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
           fetch-depth: 0
 
       - name: Install Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 22.x
           registry-url: https://registry.npmjs.org/
 
       - name: Set Git user
@@ -90,7 +90,7 @@ jobs:
       #     echo $RELEASE_VERSION
       #     echo ${{ env.RELEASE_VERSION }}
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         # NOTE: if all artifacts are downloaded,
         #       they will each put in their own folder.
 
@@ -100,7 +100,7 @@ jobs:
           echo "$s" > matrix-all.txt
 
       - name: Upload merged artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: matrix-all
           path: matrix-all.txt
@@ -121,7 +121,7 @@ jobs:
       GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
     steps:
       - name: Clean up artifacts
-        uses: geekyeggo/delete-artifact@v2
+        uses: geekyeggo/delete-artifact@v5
         with:
           name: |
             matrix-*

diff --git a/.github/workflows/test_on_pull_request.yml b/.github/workflows/test_on_pull_request.yml
@@ -10,12 +10,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [18.x, 20.x, 22.x]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           repository: vHeemstra/is-apng
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           # cache: 'npm'

diff --git a/src/index.ts b/src/index.ts
@@ -30,7 +30,7 @@ export default function isApng(buffer: Buffer | Uint8Array): boolean {
     return false
   }
 
-  // APNGs have an animation control chunk ('acTL') preceding any IDAT(s).
+  // APNGs have an animation control chunk (acTL) preceding any IDAT(s).
   // See: https://en.wikipedia.org/wiki/APNG#File_format
 
   buffer = buffer.subarray(8)