Skip to content

Conversation

@francoisdoray
Copy link

Steps:

  1. Add PostTaskImpl variants of v8::TaskRunner::PostTask methods,
    which take a v8::SourceLocation argument. Embedders should override
    these methods.
  2. Override PostTaskImpl instead of PostTask in Chromium.
  3. Override PostTaskImpl instead of PostTask in Node.js.
  4. Make Post*Task methods non-virtual and add a v8::SourceLocation
    argument which defaults to SourceLocation::Current().

Bug: chromium:1424158

@google-cla
Copy link

google-cla bot commented Apr 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@victorgomes victorgomes merged commit 776b330 into v8:node-ci-2024-03-21 Apr 17, 2024
victorgomes pushed a commit that referenced this pull request Apr 23, 2024
Co-authored-by: François Doray <fdoray@chromium.org>
victorgomes pushed a commit that referenced this pull request Jun 3, 2024
Co-authored-by: François Doray <fdoray@chromium.org>
pthier pushed a commit that referenced this pull request Jul 15, 2024
Co-authored-by: François Doray <fdoray@chromium.org>
victorgomes pushed a commit that referenced this pull request Aug 22, 2024
Co-authored-by: François Doray <fdoray@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants