Add missing TryCatch #171
Merged
Add missing TryCatch #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillobruni
approved these changes
Dec 1, 2023
pthier
pushed a commit
that referenced
this pull request
Jan 17, 2024
victorgomes
pushed a commit
that referenced
this pull request
Feb 14, 2024
victorgomes
pushed a commit
that referenced
this pull request
Mar 4, 2024
pthier
pushed a commit
that referenced
this pull request
Mar 21, 2024
victorgomes
added a commit
that referenced
this pull request
Apr 23, 2024
# Conflicts: # src/js_stream.cc
victorgomes
added a commit
that referenced
this pull request
Jun 3, 2024
# Conflicts: # src/js_stream.cc
pthier
pushed a commit
that referenced
this pull request
Jul 15, 2024
# Conflicts: # src/js_stream.cc
victorgomes
added a commit
that referenced
this pull request
Aug 22, 2024
# Conflicts: # src/js_stream.cc
pthier
pushed a commit
that referenced
this pull request
Oct 2, 2024
# Conflicts: # src/js_stream.cc
victorgomes
added a commit
that referenced
this pull request
Nov 18, 2024
# Conflicts: # src/js_stream.cc
victorgomes
added a commit
that referenced
this pull request
Dec 18, 2024
# Conflicts: # src/js_stream.cc
victorgomes
added a commit
that referenced
this pull request
Jan 20, 2025
# Conflicts: # src/js_stream.cc
pthier
pushed a commit
that referenced
this pull request
Mar 17, 2025
# Conflicts: # src/js_stream.cc
pthier
pushed a commit
that referenced
this pull request
Jun 27, 2025
# Conflicts: # src/js_stream.cc
pthier
pushed a commit
that referenced
this pull request
Aug 21, 2025
# Conflicts: # src/js_stream.cc
victorgomes
added a commit
that referenced
this pull request
Sep 26, 2025
# Conflicts: # src/js_stream.cc
pthier
pushed a commit
that referenced
this pull request
Nov 21, 2025
# Conflicts: # src/js_stream.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise re-entering v8 doesn't work as expected after exceptions were thrown.