Update V8 to 5945e1ccd0

Author: psmarshall

deps/v8/BUILD.gn

@@ -70,7 +70,8 @@ declare_args() {
 
   # Enable embedded builtins.
   # TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
-  v8_enable_embedded_builtins = v8_current_cpu != "x86" && (!is_win || is_clang)
+  # TODO(jgruber,v8:6666): Re-enable.
+  v8_enable_embedded_builtins = false
 
   # Enable code-generation-time checking of types in the CodeStubAssembler.
   v8_enable_verify_csa = false
@@ -841,6 +842,18 @@ action("postmortem-metadata") {
          rebase_path(sources, root_build_dir)
 }
 
+torque_files = [
+  "src/builtins/base.tq",
+  "src/builtins/array.tq",
+  "src/builtins/typed-array.tq",
+]
+
+torque_modules = [
+  "base",
+  "array",
+  "typed-array",
+]
+
 action("run_torque") {
   visibility = [
     ":*",
@@ -862,32 +875,61 @@ action("run_torque") {
 
   script = "tools/run.py"
 
-  inputs = [
-    "src/builtins/base.tq",
-    "src/builtins/array.tq",
-    "src/builtins/typed-array.tq",
-  ]
+  sources = torque_files
 
   outputs = [
-    "$target_gen_dir/builtin-definitions-from-dsl.h",
-    "$target_gen_dir/builtins-array-from-dsl-gen.cc",
-    "$target_gen_dir/builtins-array-from-dsl-gen.h",
-    "$target_gen_dir/builtins-base-from-dsl-gen.cc",
-    "$target_gen_dir/builtins-base-from-dsl-gen.h",
-    "$target_gen_dir/builtins-typed-array-from-dsl-gen.cc",
-    "$target_gen_dir/builtins-typed-array-from-dsl-gen.h",
+    "$target_gen_dir/torque-generated/builtin-definitions-from-dsl.h",
   ]
+  foreach(module, torque_modules) {
+    outputs += [
+      "$target_gen_dir/torque-generated/builtins-$module-from-dsl-gen.cc",
+      "$target_gen_dir/torque-generated/builtins-$module-from-dsl-gen.h",
+    ]
+  }
 
   args = [
     "./" + rebase_path(get_label_info(":torque($v8_torque_toolchain)",
                                       "root_out_dir") + "/torque",
                        root_build_dir),
     "-o",
-    rebase_path("$target_gen_dir", root_build_dir),
-    rebase_path("src/builtins/base.tq", root_build_dir),
-    rebase_path("src/builtins/array.tq", root_build_dir),
-    rebase_path("src/builtins/typed-array.tq", root_build_dir),
+    rebase_path("$target_gen_dir/torque-generated", root_build_dir),
+  ]
+
+  foreach(file, torque_files) {
+    args += [ rebase_path(file, root_build_dir) ]
+  }
+}
+
+v8_source_set("torque_generated_core") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+
+  deps = [
+    ":run_torque",
+  ]
+
+  sources = [
+    "$target_gen_dir/torque-generated/builtin-definitions-from-dsl.h",
+  ]
+
+  configs = [ ":internal_config" ]
+}
+
+v8_source_set("torque_generated_initializers") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+
+  deps = [
+    ":run_torque",
   ]
+
+  sources = []
+  foreach(module, torque_modules) {
+    sources += [
+      "$target_gen_dir/torque-generated/builtins-$module-from-dsl-gen.cc",
+      "$target_gen_dir/torque-generated/builtins-$module-from-dsl-gen.h",
+    ]
+  }
+
+  configs = [ ":internal_config" ]
 }
 
 # Template to generate different V8 snapshots based on different runtime flags.
@@ -1199,15 +1241,11 @@ v8_source_set("v8_initializers") {
   ]
 
   deps = [
-    ":run_torque",
+    ":torque_generated_initializers",
     ":v8_base",
   ]
 
   sources = [
-    "$target_gen_dir/builtins-array-from-dsl-gen.cc",
-    "$target_gen_dir/builtins-base-from-dsl-gen.cc",
-    "$target_gen_dir/builtins-typed-array-from-dsl-gen.cc",
-
     ### gcmole(all) ###
     "src/builtins/builtins-arguments-gen.cc",
     "src/builtins/builtins-arguments-gen.h",
@@ -1388,7 +1426,6 @@ v8_source_set("v8_base") {
   split_count = 2
 
   sources = [
-    "$target_gen_dir/builtin-definitions-from-dsl.h",
     "//base/trace_event/common/trace_event_common.h",
 
     ### gcmole(all) ###
@@ -1415,6 +1452,7 @@ v8_source_set("v8_base") {
     "src/api.h",
     "src/arguments.cc",
     "src/arguments.h",
+    "src/asan.h",
     "src/asmjs/asm-js.cc",
     "src/asmjs/asm-js.h",
     "src/asmjs/asm-names.h",
@@ -2698,7 +2736,7 @@ v8_source_set("v8_base") {
 
   defines = []
   deps = [
-    ":run_torque",
+    ":torque_generated_core",
     ":v8_headers",
     ":v8_libbase",
     ":v8_libsampler",
@@ -3449,7 +3487,7 @@ v8_source_set("wasm_module_runner") {
   ]
 
   deps = [
-    ":run_torque",
+    ":torque_generated_core",
   ]
 
   configs = [
@@ -3526,7 +3564,7 @@ v8_source_set("lib_wasm_fuzzer_common") {
   ]
 
   deps = [
-    ":run_torque",
+    ":torque_generated_core",
   ]
 
   configs = [

deps/v8/include/v8.h

@@ -4272,8 +4272,6 @@ class V8_EXPORT WasmModuleObjectBuilderStreaming final {
   ~WasmModuleObjectBuilderStreaming();
 
  private:
-  typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> Buffer;
-
   WasmModuleObjectBuilderStreaming(const WasmModuleObjectBuilderStreaming&) =
       delete;
   WasmModuleObjectBuilderStreaming(WasmModuleObjectBuilderStreaming&&) =
@@ -4296,8 +4294,6 @@ class V8_EXPORT WasmModuleObjectBuilderStreaming final {
 #else
   Persistent<Promise> promise_;
 #endif
-  std::vector<Buffer> received_buffers_;
-  size_t total_size_ = 0;
   std::shared_ptr<internal::wasm::StreamingDecoder> streaming_decoder_;
 };
 

deps/v8/infra/mb/mb_config.pyl

@@ -417,7 +417,8 @@
     'release_x64_gcc_coverage': [
       'release_bot', 'x64', 'coverage', 'gcc'],
     'release_x64_internal': [
-      'release_bot', 'x64', 'v8_snapshot_internal'],
+      'release_bot', 'x64', 'v8_enable_embedded_builtins',
+      'v8_snapshot_internal'],
     'release_x64_jumbo': [
       'release_bot', 'x64', 'jumbo'],
     'release_x64_jumbo_trybot': [
@@ -451,7 +452,7 @@
       'release_bot', 'x64', 'ubsan_vptr', 'minimal_symbols'],
     'release_x64_verify_csa': [
       'release_bot', 'x64', 'dcheck_always_on',
-      'v8_enable_slow_dchecks', 'v8_verify_csa'],
+      'v8_enable_slow_dchecks', 'v8_enable_embedded_builtins', 'v8_verify_csa'],
 
     # Debug configs for x64.
     'debug_x64': [
@@ -758,6 +759,10 @@
       'gn_args': 'v8_correctness_fuzzer=true v8_multi_arch_build=true',
     },
 
+    'v8_enable_embedded_builtins': {
+      'gn_args': 'v8_enable_embedded_builtins=true',
+    },
+
     'v8_enable_slow_dchecks': {
       'gn_args': 'v8_enable_slow_dchecks=true',
     },

deps/v8/src/DEPS

@@ -27,7 +27,8 @@ include_rules = [
   "+src/trap-handler/trap-handler.h",
   "+testing/gtest/include/gtest/gtest_prod.h",
   "-src/libplatform",
-  "-include/libplatform"
+  "-include/libplatform",
+  "+torque-generated"
 ]
 
 specific_include_rules = {

deps/v8/src/api.cc

@@ -5,10 +5,7 @@
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
-#ifdef V8_USE_ADDRESS_SANITIZER
-#include <sanitizer/asan_interface.h>
-#endif  // V8_USE_ADDRESS_SANITIZER
-#include <cmath>  // For isnan.
+#include <cmath>     // For isnan.
 #include <limits>
 #include <vector>
 #include "include/v8-profiler.h"
@@ -740,6 +737,8 @@ StartupData SnapshotCreator::CreateBlob(
       i::GarbageCollectionReason::kSnapshotCreator);
   isolate->heap()->CompactFixedArraysOfWeakCells();
 
+  isolate->heap()->read_only_space()->ClearStringPaddingIfNeeded();
+
   i::DisallowHeapAllocation no_gc_from_here_on;
 
   int num_contexts = num_additional_contexts + 1;
@@ -6768,8 +6767,9 @@ bool v8::String::CanMakeExternal() {
   if (obj->IsExternalString()) return false;
 
   // Old space strings should be externalized.
-  i::Isolate* isolate = obj->GetIsolate();
-  return !isolate->heap()->new_space()->Contains(*obj);
+  i::Heap* heap = obj->GetIsolate()->heap();
+  return !heap->new_space()->Contains(*obj) &&
+         !heap->read_only_space()->Contains(*obj);
 }
 
 
@@ -7514,15 +7514,13 @@ WasmModuleObjectBuilderStreaming::WasmModuleObjectBuilderStreaming(
   Local<Promise::Resolver> resolver = maybe_resolver.ToLocalChecked();
   promise_.Reset(isolate, resolver->GetPromise());
 
-  if (i::FLAG_wasm_stream_compilation) {
-    i::Handle<i::JSPromise> promise = Utils::OpenHandle(*GetPromise());
-    i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
-    streaming_decoder_ =
-        i_isolate->wasm_engine()
-            ->compilation_manager()
-            ->StartStreamingCompilation(i_isolate, handle(i_isolate->context()),
-                                        promise);
-  }
+  i::Handle<i::JSPromise> promise = Utils::OpenHandle(*GetPromise());
+  i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
+  streaming_decoder_ =
+      i_isolate->wasm_engine()
+          ->compilation_manager()
+          ->StartStreamingCompilation(i_isolate, handle(i_isolate->context()),
+                                      promise);
 }
 
 Local<Promise> WasmModuleObjectBuilderStreaming::GetPromise() {
@@ -7531,46 +7529,19 @@ Local<Promise> WasmModuleObjectBuilderStreaming::GetPromise() {
 
 void WasmModuleObjectBuilderStreaming::OnBytesReceived(const uint8_t* bytes,
                                                        size_t size) {
-  if (i::FLAG_wasm_stream_compilation) {
-    streaming_decoder_->OnBytesReceived(i::Vector<const uint8_t>(bytes, size));
-    return;
-  }
-  std::unique_ptr<uint8_t[]> cloned_bytes(new uint8_t[size]);
-  memcpy(cloned_bytes.get(), bytes, size);
-  received_buffers_.push_back(
-      Buffer(std::unique_ptr<const uint8_t[]>(
-                 const_cast<const uint8_t*>(cloned_bytes.release())),
-             size));
-  total_size_ += size;
+  streaming_decoder_->OnBytesReceived(i::Vector<const uint8_t>(bytes, size));
 }
 
 void WasmModuleObjectBuilderStreaming::Finish() {
-  if (i::FLAG_wasm_stream_compilation) {
-    streaming_decoder_->Finish();
-    return;
-  }
-  std::unique_ptr<uint8_t[]> wire_bytes(new uint8_t[total_size_]);
-  uint8_t* insert_at = wire_bytes.get();
-
-  for (size_t i = 0; i < received_buffers_.size(); ++i) {
-    const Buffer& buff = received_buffers_[i];
-    memcpy(insert_at, buff.first.get(), buff.second);
-    insert_at += buff.second;
-  }
-  // AsyncCompile makes its own copy of the wire bytes. This inefficiency
-  // will be resolved when we move to true streaming compilation.
-  auto i_isolate = reinterpret_cast<i::Isolate*>(isolate_);
-  i_isolate->wasm_engine()->AsyncCompile(
-      i_isolate, Utils::OpenHandle(*promise_.Get(isolate_)),
-      {wire_bytes.get(), wire_bytes.get() + total_size_}, false);
+  streaming_decoder_->Finish();
 }
 
 void WasmModuleObjectBuilderStreaming::Abort(MaybeLocal<Value> exception) {
   Local<Promise> promise = GetPromise();
   // The promise has already been resolved, e.g. because of a compilation
   // error.
   if (promise->State() != v8::Promise::kPending) return;
-  if (i::FLAG_wasm_stream_compilation) streaming_decoder_->Abort();
+  streaming_decoder_->Abort();
 
   // If no exception value is provided, we do not reject the promise. This can
   // happen when streaming compilation gets aborted when no script execution is

deps/v8/src/asan.h

@@ -0,0 +1,30 @@
+// Copyright 2018 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// AddressSanitizer support.
+
+#ifndef V8_ASAN_H_
+#define V8_ASAN_H_
+
+#include "src/base/macros.h"
+#include "src/globals.h"
+
+#ifdef V8_USE_ADDRESS_SANITIZER
+
+#include <sanitizer/asan_interface.h>
+
+#else  // !V8_USE_ADDRESS_SANITIZER
+
+#define ASAN_POISON_MEMORY_REGION(start, size)                         \
+  static_assert(                                                       \
+      (std::is_pointer<decltype(start)>::value ||                      \
+       std::is_same<v8::internal::Address, decltype(start)>::value) && \
+          std::is_convertible<decltype(size), size_t>::value,          \
+      "static type violation")
+#define ASAN_UNPOISON_MEMORY_REGION(start, size) \
+  ASAN_POISON_MEMORY_REGION(start, size)
+
+#endif  // V8_USE_ADDRESS_SANITIZER
+
+#endif  // V8_ASAN_H_

deps/v8/src/base/macros.h

@@ -149,20 +149,27 @@ V8_INLINE Dest bit_cast(Source const& source) {
 #define INLINE(declarator)    V8_INLINE declarator
 #define NO_INLINE(declarator) V8_NOINLINE declarator
 
-// Define V8_USE_ADDRESS_SANITIZER macros.
+// Define V8_USE_ADDRESS_SANITIZER macro.
 #if defined(__has_feature)
 #if __has_feature(address_sanitizer)
 #define V8_USE_ADDRESS_SANITIZER 1
 #endif
 #endif
 
-// Define DISABLE_ASAN macros.
+// Define DISABLE_ASAN macro.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #define DISABLE_ASAN __attribute__((no_sanitize_address))
 #else
 #define DISABLE_ASAN
 #endif
 
+// Define V8_USE_MEMORY_SANITIZER macro.
+#if defined(__has_feature)
+#if __has_feature(memory_sanitizer)
+#define V8_USE_MEMORY_SANITIZER 1
+#endif
+#endif
+
 // Helper macro to define no_sanitize attributes only with clang.
 #if defined(__clang__) && defined(__has_attribute)
 #if __has_attribute(no_sanitize)