Update V8 to 33157f3de7

Author: psmarshall

deps/v8/.gitattributes

@@ -0,0 +1,2 @@
+# Automatically normalize line endings (to LF) for all text-based files.
+* text=auto

deps/v8/BUILD.gn

@@ -1575,6 +1575,8 @@ v8_source_set("v8_base") {
     "src/compiler/common-operator.h",
     "src/compiler/compiler-source-position-table.cc",
     "src/compiler/compiler-source-position-table.h",
+    "src/compiler/constant-folding-reducer.cc",
+    "src/compiler/constant-folding-reducer.h",
     "src/compiler/control-equivalence.cc",
     "src/compiler/control-equivalence.h",
     "src/compiler/control-flow-optimizer.cc",
@@ -1725,6 +1727,8 @@ v8_source_set("v8_base") {
     "src/compiler/store-store-elimination.h",
     "src/compiler/type-cache.cc",
     "src/compiler/type-cache.h",
+    "src/compiler/type-narrowing-reducer.cc",
+    "src/compiler/type-narrowing-reducer.h",
     "src/compiler/typed-optimization.cc",
     "src/compiler/typed-optimization.h",
     "src/compiler/typer.cc",
@@ -2065,6 +2069,9 @@ v8_source_set("v8_base") {
     "src/objects/name.h",
     "src/objects/object-macros-undef.h",
     "src/objects/object-macros.h",
+    "src/objects/ordered-hash-table-inl.h",
+    "src/objects/ordered-hash-table.cc",
+    "src/objects/ordered-hash-table.h",
     "src/objects/promise-inl.h",
     "src/objects/promise.h",
     "src/objects/property-descriptor-object-inl.h",
@@ -3042,6 +3049,7 @@ if (current_toolchain == v8_snapshot_toolchain) {
       "src/torque/ast-generator.cc",
       "src/torque/ast-generator.h",
       "src/torque/ast.h",
+      "src/torque/declarable.cc",
       "src/torque/declarable.h",
       "src/torque/declaration-visitor.cc",
       "src/torque/declaration-visitor.h",

deps/v8/DEPS

@@ -12,7 +12,7 @@ vars = {
 
 deps = {
   'v8/build':
-    Var('chromium_url') + '/chromium/src/build.git' + '@' + '506800f4cea285ae0cf22221c8a515890a862694',
+    Var('chromium_url') + '/chromium/src/build.git' + '@' + '1fd2d08a6f951a6a57ca175c75ca29740003fbf0',
   'v8/tools/gyp':
     Var('chromium_url') + '/external/gyp.git' + '@' + 'd61a9397e668fa9843c4aa7da9e79460fe590bfb',
   'v8/third_party/icu':

deps/v8/include/libplatform/v8-tracing.h

@@ -112,6 +112,8 @@ class V8_PLATFORM_EXPORT TraceWriter {
   virtual void Flush() = 0;
 
   static TraceWriter* CreateJSONTraceWriter(std::ostream& stream);
+  static TraceWriter* CreateJSONTraceWriter(std::ostream& stream,
+                                            const std::string& tag);
 
  private:
   // Disallow copy and assign

deps/v8/include/v8-inspector.h

@@ -99,6 +99,7 @@ class V8_EXPORT V8ContextInfo {
 
 class V8_EXPORT V8StackTrace {
  public:
+  virtual StringView firstNonEmptySourceURL() const = 0;
   virtual bool isEmpty() const = 0;
   virtual StringView topSourceURL() const = 0;
   virtual int topLineNumber() const = 0;

deps/v8/infra/testing/PRESUBMIT.py

@@ -165,16 +165,15 @@ def file_filter(regexp):
 
   # Calculate which files are affected.
   if input_api.AffectedFiles(False, file_filter(r'.*PRESUBMIT\.py')):
-    # If PRESUBMIT.py itself was changed, check all configs.
+    # If PRESUBMIT.py itself was changed, check also the test spec.
     affected_files = [
-      f for f in os.listdir(input_api.PresubmitLocalPath())
-      if f.endswith('.pyl')
+      os.path.join(input_api.PresubmitLocalPath(), 'builders.pyl'),
     ]
   else:
-    # Otherwise, check only changed configs.
+    # Otherwise, check test spec only when changed.
     affected_files = [
       f.AbsoluteLocalPath()
-      for f in input_api.AffectedFiles(False, file_filter(r'.+\.pyl'))
+      for f in input_api.AffectedFiles(False, file_filter(r'.*builders\.pyl'))
     ]
 
   errors = []

deps/v8/infra/testing/README.md

@@ -7,11 +7,10 @@ variants specified [here](https://chromium.googlesource.com/v8/v8/+/master/tools
 Changes to src-side test specifications go through CQ like any other CL and
 require tests added for specific trybots to pass.
 
-The test specifications are defined in a V8-side folder called infra/testing.
-Every master has an optional file named `<mastername>.pyl`. E.g.
-`tryserver.v8.pyl`.
+The test specifications are defined in a V8-side python-literal file
+`infra/testing/builders.pyl`.
 
-The structure of each file is:
+The structure of the file is:
 ```
 {
   <buildername>: {

deps/v8/infra/testing/tryserver.v8.pyl renamed to deps/v8/infra/testing/builders.pyl

@@ -1,15 +1,10 @@
-# Copyright 2017 The V8 project authors. All rights reserved.
+# Copyright 2018 The V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
-  ### Example configuration for trybots (please keep as reference).
-  # 'v8_linux64_rel_ng_triggered': {
-  #   'tests': [
-  #     {'name': 'benchmarks', 'variant': 'default', 'shards': 1},
-  #   ],
-  # },
-
+  ##############################################################################
+  ### luci.v8.try
   ##############################################################################
   # Linux32
   'v8_linux_dbg_ng_triggered': {
@@ -257,4 +252,60 @@
       {'name': 'v8testing', 'variant': 'extra'},
     ],
   },
+  ##############################################################################
+  ### luci.v8.ci
+  ##############################################################################
+  # Linux32
+  'V8 Linux - debug': {
+    'tests': [
+      {'name': 'd8testing', 'variant': 'code_serializer', 'shards': 1},
+      {'name': 'mozilla', 'variant': 'code_serializer', 'shards': 1},
+      {'name': 'test262_variants', 'variant': 'code_serializer', 'shards': 1},
+      {'name': 'benchmarks', 'variant': 'code_serializer', 'shards': 1},
+    ],
+  },
+  'V8 Linux - gc stress': {
+    'tests': [
+      {'name': 'mjsunit', 'variant': 'slow_path', 'shards': 2},
+    ],
+  },
+  ##############################################################################
+  # Linux64
+  'V8 Linux64': {
+    'tests': [
+      {'name': 'v8testing', 'variant': 'minor_mc', 'shards': 1},
+    ],
+  },
+  'V8 Linux64 - debug': {
+    'tests': [
+      {'name': 'v8testing', 'variant': 'minor_mc', 'shards': 1},
+      {'name': 'v8testing', 'variant': 'slow_path', 'shards': 1},
+    ],
+  },
+  'V8 Linux64 - debug - fyi': {
+    'tests': [
+      {'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2},
+      {'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 3},
+      {'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1},
+      {'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1},
+    ],
+  },
+  'V8 Linux64 - fyi': {
+    'tests': [
+      {'name': 'v8testing', 'variant': 'infra_staging', 'shards': 1},
+      {'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 2},
+      {'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1},
+      {'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1},
+    ],
+  },
+  'V8 Linux64 ASAN': {
+    'tests': [
+      {'name': 'v8testing', 'variant': 'slow_path', 'shards': 1},
+    ],
+  },
+  'V8 Linux64 TSAN': {
+    'tests': [
+      {'name': 'v8testing', 'variant': 'slow_path', 'shards': 1},
+    ],
+  },
 }

deps/v8/infra/testing/client.v8.pyl

@@ -783,7 +783,7 @@ StartupData SnapshotCreator::CreateBlob(
       if (shared->CanFlushCompiled()) {
         shared->FlushCompiled();
       }
-      DCHECK(shared->HasCodeObject() || shared->HasBuiltinId() ||
+      DCHECK(shared->HasWasmExportedFunctionData() || shared->HasBuiltinId() ||
              shared->IsApiFunction());
     }
   }
@@ -5135,10 +5135,12 @@ MaybeLocal<Object> Function::NewInstanceWithSideEffectType(
   i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);
   auto self = Utils::OpenHandle(this);
   STATIC_ASSERT(sizeof(v8::Local<v8::Value>) == sizeof(i::Object**));
-  if (side_effect_type == SideEffectType::kHasNoSideEffect) {
+  bool should_set_has_no_side_effect =
+      side_effect_type == SideEffectType::kHasNoSideEffect &&
+      isolate->debug_execution_mode() == i::DebugInfo::kSideEffects;
+  if (should_set_has_no_side_effect) {
     CHECK(self->IsJSFunction() &&
           i::JSFunction::cast(*self)->shared()->IsApiFunction());
-    DCHECK(isolate->debug_execution_mode() == i::DebugInfo::kSideEffects);
     i::Object* obj =
         i::JSFunction::cast(*self)->shared()->get_api_func_data()->call_code();
     if (obj->IsCallHandlerInfo()) {
@@ -5152,7 +5154,7 @@ MaybeLocal<Object> Function::NewInstanceWithSideEffectType(
   Local<Object> result;
   has_pending_exception = !ToLocal<Object>(
       i::Execution::New(isolate, self, self, argc, args), &result);
-  if (side_effect_type == SideEffectType::kHasNoSideEffect) {
+  if (should_set_has_no_side_effect) {
     i::Object* obj =
         i::JSFunction::cast(*self)->shared()->get_api_func_data()->call_code();
     if (obj->IsCallHandlerInfo()) {
@@ -9836,15 +9838,7 @@ Local<String> CpuProfileNode::GetFunctionName() const {
   const i::CodeEntry* entry = node->entry();
   i::Handle<i::String> name =
       isolate->factory()->InternalizeUtf8String(entry->name());
-  if (!entry->has_name_prefix()) {
-    return ToApiHandle<String>(name);
-  } else {
-    // We do not expect this to fail. Change this if it does.
-    i::Handle<i::String> cons = isolate->factory()->NewConsString(
-        isolate->factory()->InternalizeUtf8String(entry->name_prefix()),
-        name).ToHandleChecked();
-    return ToApiHandle<String>(cons);
-  }
+  return ToApiHandle<String>(name);
 }
 
 int debug::Coverage::BlockData::StartOffset() const { return block_->start; }