Skip to content

fix: Initialize animatedOnlineCount when view appears with stats #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2025
Merged

fix: Initialize animatedOnlineCount when view appears with stats #58

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
630bd20
fix: Initialize animatedOnlineCount when view appears with stats
graycreate Oct 18, 2025
caffb4c
chore: Change default TestFlight release to internal testing
graycreate Oct 18, 2025
3a2b740
feat: Add configurable release channel parameter
graycreate Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions V2er/View/Widget/Updatable/HeadIndicatorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ struct HeadIndicatorView: View {
.foregroundColor(.secondaryText)
}
}
.onAppear {
// Initialize animatedOnlineCount when view appears with valid stats
if animatedOnlineCount == 0 && stats.onlineCount > 0 {
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition animatedOnlineCount == 0 could prevent legitimate updates if the actual online count is 0. If the view appears when stats.onlineCount is 0 and later increases, the initialization won't trigger on subsequent appearances. Consider using a more explicit flag to track initialization state, or simplify the condition to just check if stats.onlineCount > 0.

Suggested change
if animatedOnlineCount == 0 && stats.onlineCount > 0 {
if animatedOnlineCount != stats.onlineCount {

Copilot uses AI. Check for mistakes.
animatedOnlineCount = stats.onlineCount
}
}
.onChange(of: stats.onlineCount) { newValue in
withAnimation(.easeInOut(duration: 0.3)) {
animatedOnlineCount = newValue
Expand Down
Loading