Add green indicator dot to online user count #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a small green dot (#52bf1c) to the left of the online user count text in the pull-to-refresh indicator for better visual indication. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a visual indicator to the online user count display by placing a small green dot next to the count text in the pull-to-refresh header view.
- Adds a 6x6pt green circle (#52bf1c) as a status indicator
- Implements HStack layout with 4pt spacing to position the dot before the text
- Uses the existing Color.hex() utility for color specification
Code Coverage Report ❌Current coverage: 0% |
Improvements to the online user count display: 1. Apply SwiftUI numericText animation when count changes (iOS 16+) 2. Add 300ms delay before hiding refresh indicator when count changes 3. Record previous count to detect changes during refresh This creates a smoother UX by: - Animating number transitions instead of instant changes - Keeping the indicator visible longer when data updates - Allowing users to see the count change before it disappears 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Code Coverage Report ❌Current coverage: 0% |
graycreate
added a commit
that referenced
this pull request
Oct 18, 2025
Problem: - In v1.1.4, online count always shows as 0 - animatedOnlineCount is initialized to 0 as default - When onlineStats changes from nil to a value, animatedOnlineCount stays at 0 - onChange only triggers when the value changes, not on initial load Solution: - Add onAppear to initialize animatedOnlineCount from stats.onlineCount - Check if animatedOnlineCount is 0 and stats has valid count - This ensures the count displays correctly on first load Fixes the regression introduced in PR #57 where animated count feature broke the initial display of online user count.
graycreate
added a commit
that referenced
this pull request
Oct 18, 2025
* fix: Initialize animatedOnlineCount when view appears with stats Problem: - In v1.1.4, online count always shows as 0 - animatedOnlineCount is initialized to 0 as default - When onlineStats changes from nil to a value, animatedOnlineCount stays at 0 - onChange only triggers when the value changes, not on initial load Solution: - Add onAppear to initialize animatedOnlineCount from stats.onlineCount - Check if animatedOnlineCount is 0 and stats has valid count - This ensures the count displays correctly on first load Fixes the regression introduced in PR #57 where animated count feature broke the initial display of online user count. * chore: Change default TestFlight release to internal testing - Set distribute_external to false (internal testing only) - Remove public beta groups and external tester notifications - Skip beta review submission for internal builds - Update workflow and lane descriptions - Simplify upload_to_testflight parameters This allows faster iteration and testing without requiring Beta App Review approval for each build. Public beta releases can still be done manually through App Store Connect when needed. * feat: Add configurable release channel parameter - Add 'release_channel' workflow input (internal/public_beta) - Default to 'internal' for automatic releases - Support 'public_beta' for manual workflow_dispatch - Fastlane beta lane now accepts channel parameter - Dynamically configure TestFlight distribution based on channel: - internal: No beta review, internal testers only - public_beta: Submit for beta review, notify external testers - Update GitHub Release notes to reflect selected channel - Update notification messages based on channel Usage: - Automatic (push to main): Uses 'internal' by default - Manual workflow: Can select 'public_beta' in workflow dispatch UI - Local fastlane: fastlane beta channel:public_beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
HeadIndicatorView.swift:.contentTransition(.numericText())(iOS 16+)UpdatableView.swift:Features
Test Plan
🤖 Generated with Claude Code