feat: Implement scroll-to-top for native TabView #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement proper SwiftUI approach for detecting tab reselection: - Add Combine PassthroughSubject to capture all tab taps - Create intermediate binding that publishes tap events - Use onReceive to dispatch TabbarClickAction for scroll-to-top - Works for both tab switches and same-tab taps - Pure SwiftUI solution without UIKit introspection This enables the native iOS behavior where tapping an active tab scrolls content to the top, matching standard iOS app behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
Implements proper SwiftUI approach for detecting tab reselection to enable scroll-to-top behavior when tapping an already-selected tab item, using Combine PassthroughSubject and intermediate binding instead of UIKit introspection.
- Adds Combine framework integration with PassthroughSubject to capture all tab tap events
- Creates intermediate binding that publishes events for both tab switches and same-tab taps
- Uses onReceive modifier to dispatch TabbarClickAction for all tab interactions
Code Coverage Report ❌Current coverage: 0% |
Apply Copilot suggestion to always update selectedTab binding value, even when tapping the same tab. This ensures the TabView selection stays in sync and simplifies the binding logic. Setting the same value is harmless in SwiftUI and prevents potential sync issues between the intermediate binding and the actual state. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the proper SwiftUI approach for detecting tab reselection to enable scroll-to-top behavior when tapping an active tab item.
Changes
PassthroughSubjectto capture all tab tap eventsonReceivemodifier to dispatchTabbarClickActionfor all tab interactionsBehavior
This enables the standard iOS behavior where tapping an already-selected tab scrolls the content to the top, matching the UX of native iOS apps like Safari, Settings, etc.
Technical Details
PassthroughSubjectpublishes the event even when tapping the same tabTabbarClickActionand reducer logic handle the scroll-to-top functionalityTest Plan
🤖 Generated with Claude Code