fix: properly integrate xcconfig for true single-source version management #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Version.xcconfig as the single source of truth for versions - Linked xcconfig to project configurations via baseConfigurationReference - Removed all hardcoded version values from project.pbxproj - Added Config group to project structure with xcconfig file - Updated documentation to reflect the correct process Now only need to edit V2er/Config/Version.xcconfig to update versions! No more updating multiple places in project.pbxproj.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes xcconfig integration to achieve true single-source version management by properly linking the Version.xcconfig file to Xcode project configurations and removing hardcoded version values.
- Properly integrates Version.xcconfig by adding baseConfigurationReference links to project configurations
- Removes all hardcoded version values from project.pbxproj to eliminate duplication
- Updates documentation to reflect the simplified single-file version management process
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| VERSIONING.md | Updated documentation to reflect simplified single-file version management process |
| V2er/Config/Version.xcconfig | Incremented VERSION_CODE from 29 to 30 for testing |
| V2er.xcodeproj/project.pbxproj | Added xcconfig file reference, Config group, and baseConfigurationReference links while removing hardcoded versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| CURRENT_PROJECT_VERSION = 29; /* VERSION_CODE */ | ||
| # Update these two lines: | ||
| MARKETING_VERSION = 1.1.2 # VERSION_NAME (user-facing version) | ||
| CURRENT_PROJECT_VERSION = 29 # VERSION_CODE (build number) |
There was a problem hiding this comment.
The documentation shows VERSION_CODE as 29, but the actual Version.xcconfig file was updated to 30. This creates inconsistency between the documentation example and the actual configuration.
Suggested change
| CURRENT_PROJECT_VERSION = 29 # VERSION_CODE (build number) | |
| CURRENT_PROJECT_VERSION = 30 # VERSION_CODE (build number) |
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
✅ Fixed xcconfig integration so versions are truly defined in ONE place only
Problem
Previously created Version.xcconfig but it wasn't actually being used by Xcode. The versions were still hardcoded in project.pbxproj in 4 places.
Solution
Result
Now to update versions, you ONLY need to edit:
Change these two lines:
That's it! No more editing project.pbxproj in multiple places.
Testing
🤖 Generated with Claude Code