- 
                Notifications
    You must be signed in to change notification settings 
- Fork 48
feat: iOS Release Pipeline with Fastlane Match #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            2 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,19 +1,16 @@ | ||||||||
| name: Release to App Store | ||||||||
| name: iOS Release Pipeline | ||||||||
|  | ||||||||
| on: | ||||||||
| push: | ||||||||
| branches: | ||||||||
| - main | ||||||||
| paths: | ||||||||
| - 'V2er/Info.plist' | ||||||||
| - 'V2er.xcodeproj/project.pbxproj' | ||||||||
| workflow_dispatch: | ||||||||
| inputs: | ||||||||
| release_type: | ||||||||
| description: 'Release type' | ||||||||
| required: true | ||||||||
| default: 'patch' | ||||||||
| type: choice | ||||||||
| options: | ||||||||
| - patch | ||||||||
| - minor | ||||||||
| - major | ||||||||
| testflight_only: | ||||||||
| description: 'TestFlight only (no App Store release)' | ||||||||
| force_release: | ||||||||
| description: 'Force release even if version unchanged' | ||||||||
| required: false | ||||||||
| default: false | ||||||||
| type: boolean | ||||||||
|  | @@ -22,197 +19,157 @@ env: | |||||||
| DEVELOPER_DIR: /Applications/Xcode.app/Contents/Developer | ||||||||
|  | ||||||||
| jobs: | ||||||||
| release: | ||||||||
| name: Build and Release | ||||||||
| runs-on: macos-latest | ||||||||
|  | ||||||||
| version-check: | ||||||||
| name: Check Version and Create Tag | ||||||||
| runs-on: ubuntu-latest | ||||||||
| outputs: | ||||||||
| should_release: ${{ steps.check.outputs.should_release }} | ||||||||
| new_tag: ${{ steps.check.outputs.new_tag }} | ||||||||
| version: ${{ steps.check.outputs.version }} | ||||||||
| build: ${{ steps.check.outputs.build }} | ||||||||
|  | ||||||||
| steps: | ||||||||
| - name: Checkout repository | ||||||||
| uses: actions/checkout@v4 | ||||||||
| with: | ||||||||
| fetch-depth: 0 | ||||||||
| token: ${{ secrets.GITHUB_TOKEN }} | ||||||||
|  | ||||||||
| - name: Check version and create tag if needed | ||||||||
| id: check | ||||||||
| run: | | ||||||||
| # Get current version from Info.plist | ||||||||
| CURRENT_VERSION=$(grep -A1 "CFBundleShortVersionString" V2er/Info.plist | tail -1 | sed 's/.*<string>\(.*\)<\/string>/\1/' | xargs) | ||||||||
| CURRENT_BUILD=$(grep -A1 "CFBundleVersion" V2er/Info.plist | tail -1 | sed 's/.*<string>\(.*\)<\/string>/\1/' | xargs) | ||||||||
|  | ||||||||
| echo "Current version: $CURRENT_VERSION (build $CURRENT_BUILD)" | ||||||||
|  | ||||||||
| # Check if tag already exists | ||||||||
| TAG_NAME="v$CURRENT_VERSION" | ||||||||
|  | ||||||||
| if git rev-parse "$TAG_NAME" >/dev/null 2>&1; then | ||||||||
| if [[ "${{ github.event.inputs.force_release }}" == "true" ]]; then | ||||||||
| echo "Tag $TAG_NAME exists but force_release is true" | ||||||||
| # Delete existing tag for force release | ||||||||
| git push origin --delete "$TAG_NAME" 2>/dev/null || true | ||||||||
| echo "should_release=true" >> $GITHUB_OUTPUT | ||||||||
| else | ||||||||
| echo "Tag $TAG_NAME already exists, skipping release" | ||||||||
| echo "should_release=false" >> $GITHUB_OUTPUT | ||||||||
| fi | ||||||||
| else | ||||||||
| echo "Tag $TAG_NAME does not exist, will create it" | ||||||||
| echo "should_release=true" >> $GITHUB_OUTPUT | ||||||||
| fi | ||||||||
|  | ||||||||
| echo "new_tag=$TAG_NAME" >> $GITHUB_OUTPUT | ||||||||
| echo "version=$CURRENT_VERSION" >> $GITHUB_OUTPUT | ||||||||
| echo "build=$CURRENT_BUILD" >> $GITHUB_OUTPUT | ||||||||
|  | ||||||||
| - name: Create and push tag | ||||||||
| if: steps.check.outputs.should_release == 'true' | ||||||||
| run: | | ||||||||
| git config --local user.email "action@github.com" | ||||||||
| git config --local user.name "GitHub Action" | ||||||||
|  | ||||||||
| TAG_NAME="${{ steps.check.outputs.new_tag }}" | ||||||||
| VERSION="${{ steps.check.outputs.version }}" | ||||||||
| BUILD="${{ steps.check.outputs.build }}" | ||||||||
|  | ||||||||
| # Create annotated tag | ||||||||
| git tag -a "$TAG_NAME" -m "Release version $VERSION (build $BUILD)" | ||||||||
|  | ||||||||
| # Push tag | ||||||||
| git push origin "$TAG_NAME" | ||||||||
|  | ||||||||
| echo "✅ Successfully created tag: $TAG_NAME" | ||||||||
|  | ||||||||
| build-and-release: | ||||||||
| name: Build and Release to TestFlight | ||||||||
| needs: version-check | ||||||||
| if: needs.version-check.outputs.should_release == 'true' | ||||||||
| runs-on: macos-latest | ||||||||
|  | ||||||||
| steps: | ||||||||
| - name: Checkout repository at tag | ||||||||
| uses: actions/checkout@v4 | ||||||||
| with: | ||||||||
| submodules: recursive | ||||||||
| fetch-depth: 0 | ||||||||
|  | ||||||||
| ref: ${{ needs.version-check.outputs.new_tag }} | ||||||||
|  | ||||||||
| - name: Select Xcode version | ||||||||
| run: sudo xcode-select -s /Applications/Xcode_16.0.app/Contents/Developer | ||||||||
|  | ||||||||
| - name: Setup Ruby | ||||||||
| uses: ruby/setup-ruby@v1 | ||||||||
| with: | ||||||||
| ruby-version: '3.0' | ||||||||
| bundler-cache: true | ||||||||
| bundler-cache: false | ||||||||
|  | ||||||||
| - name: Install Fastlane | ||||||||
| run: | | ||||||||
| gem install fastlane | ||||||||
| gem install xcpretty | ||||||||
|  | ||||||||
| - name: Configure Git | ||||||||
| run: | | ||||||||
| git config --local user.email "action@github.com" | ||||||||
| git config --local user.name "GitHub Action" | ||||||||
|  | ||||||||
| - name: Import certificates | ||||||||
| env: | ||||||||
| CERTIFICATES_P12: ${{ secrets.CERTIFICATES_P12 }} | ||||||||
| CERTIFICATES_PASSWORD: ${{ secrets.CERTIFICATES_PASSWORD }} | ||||||||
| KEYCHAIN_PASSWORD: ${{ secrets.KEYCHAIN_PASSWORD }} | ||||||||
| run: | | ||||||||
| # Create variables | ||||||||
| CERTIFICATE_PATH=$RUNNER_TEMP/certificate.p12 | ||||||||
| KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db | ||||||||
|  | ||||||||
| # Import certificate from secrets | ||||||||
| echo -n "$CERTIFICATES_P12" | base64 --decode -o $CERTIFICATE_PATH | ||||||||
|  | ||||||||
| # Create temporary keychain | ||||||||
| security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH | ||||||||
| security set-keychain-settings -lut 21600 $KEYCHAIN_PATH | ||||||||
| security unlock-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH | ||||||||
|  | ||||||||
| # Import certificate to keychain | ||||||||
| security import $CERTIFICATE_PATH -P "$CERTIFICATES_PASSWORD" -A -t cert -f pkcs12 -k $KEYCHAIN_PATH | ||||||||
| security list-keychain -d user -s $KEYCHAIN_PATH | ||||||||
|  | ||||||||
| - name: Download provisioning profiles | ||||||||
|  | ||||||||
| - name: Setup SSH for Match repository | ||||||||
| uses: webfactory/ssh-agent@v0.8.0 | ||||||||
| with: | ||||||||
| ssh-private-key: ${{ secrets.DEPLOY_KEY }} | ||||||||
|  | ||||||||
| - name: Create App Store Connect API Key | ||||||||
| env: | ||||||||
| PROVISIONING_PROFILE_BASE64: ${{ secrets.PROVISIONING_PROFILE_BASE64 }} | ||||||||
| run: | | ||||||||
| # Create the provisioning profiles directory | ||||||||
| mkdir -p ~/Library/MobileDevice/Provisioning\ Profiles | ||||||||
|  | ||||||||
| # Decode and save provisioning profile | ||||||||
| echo -n "$PROVISIONING_PROFILE_BASE64" | base64 --decode -o ~/Library/MobileDevice/Provisioning\ Profiles/V2er.mobileprovision | ||||||||
|  | ||||||||
| - name: Bump version | ||||||||
| id: version | ||||||||
| APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }} | ||||||||
| APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }} | ||||||||
| APP_STORE_CONNECT_API_KEY_BASE64: ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} | ||||||||
| run: | | ||||||||
| # Get current version | ||||||||
| CURRENT_VERSION=$(xcodebuild -project V2er.xcodeproj -showBuildSettings | grep MARKETING_VERSION | tr -d 'MARKETING_VERSION = ') | ||||||||
| echo "Current version: $CURRENT_VERSION" | ||||||||
|  | ||||||||
| # Calculate new version based on input | ||||||||
| IFS='.' read -ra VERSION_PARTS <<< "$CURRENT_VERSION" | ||||||||
| MAJOR=${VERSION_PARTS[0]} | ||||||||
| MINOR=${VERSION_PARTS[1]} | ||||||||
| PATCH=${VERSION_PARTS[2]} | ||||||||
|  | ||||||||
| case "${{ github.event.inputs.release_type }}" in | ||||||||
| major) | ||||||||
| NEW_VERSION="$((MAJOR + 1)).0.0" | ||||||||
| ;; | ||||||||
| minor) | ||||||||
| NEW_VERSION="$MAJOR.$((MINOR + 1)).0" | ||||||||
| ;; | ||||||||
| patch) | ||||||||
| NEW_VERSION="$MAJOR.$MINOR.$((PATCH + 1))" | ||||||||
| ;; | ||||||||
| esac | ||||||||
|  | ||||||||
| echo "New version: $NEW_VERSION" | ||||||||
| echo "version=$NEW_VERSION" >> $GITHUB_OUTPUT | ||||||||
|  | ||||||||
| # Update version in project | ||||||||
| xcrun agvtool new-marketing-version $NEW_VERSION | ||||||||
|  | ||||||||
| # Get and increment build number | ||||||||
| BUILD_NUMBER=$(xcodebuild -project V2er.xcodeproj -showBuildSettings | grep CURRENT_PROJECT_VERSION | tr -d 'CURRENT_PROJECT_VERSION = ') | ||||||||
| NEW_BUILD_NUMBER=$((BUILD_NUMBER + 1)) | ||||||||
| xcrun agvtool new-version -all $NEW_BUILD_NUMBER | ||||||||
|  | ||||||||
| - name: Archive app | ||||||||
| mkdir -p ~/.appstoreconnect/private_keys | ||||||||
| echo "$APP_STORE_CONNECT_API_KEY_BASE64" | base64 --decode > ~/.appstoreconnect/private_keys/AuthKey_${APP_STORE_CONNECT_KEY_ID}.p8 | ||||||||
| 
     | ||||||||
| echo "$APP_STORE_CONNECT_API_KEY_BASE64" | base64 --decode > ~/.appstoreconnect/private_keys/AuthKey_${APP_STORE_CONNECT_KEY_ID}.p8 | |
| echo "$APP_STORE_CONNECT_API_KEY_BASE64" | base64 --decode > ~/.appstoreconnect/private_keys/AuthKey_${APP_STORE_CONNECT_KEY_ID}.p8 | |
| chmod 600 ~/.appstoreconnect/private_keys/AuthKey_${APP_STORE_CONNECT_KEY_ID}.p8 | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Appfile - App specific configuration | ||
|  | ||
| # App Bundle ID | ||
| app_identifier("v2er.app") | ||
|  | ||
| # Apple ID (optional if using API key) | ||
| # apple_id("your@email.com") | ||
|  | ||
| # Team ID from Apple Developer Portal | ||
| team_id(ENV["TEAM_ID"]) | ||
|  | ||
| # iTunes Connect Team ID (if different from Developer Portal team) | ||
| itc_team_id(ENV["ITC_TEAM_ID"] || ENV["TEAM_ID"]) | ||
|  | ||
| # You can set different app identifiers per lane | ||
| for_lane :beta do | ||
| app_identifier("v2er.app") | ||
| end | ||
|  | ||
| for_lane :release do | ||
| app_identifier("v2er.app") | ||
| end | 
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex patterns for parsing Info.plist are complex and fragile. Consider using a more robust XML parser like
plutilorPlistBuddywhich are available on the runner and handle XML parsing more reliably.