Fix: Display real version number in Settings About section #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed hardcoded version "版本1.0.0" to dynamically read from Bundle - Now displays version in format "版本v1.1.0(3)" with actual version and build number - Version info is pulled from CFBundleShortVersionString and CFBundleVersion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hardcoded version display issue in the Settings About section by implementing dynamic version reading from the app bundle. Instead of showing a static "版本1.0.0", the app now displays the actual version and build number in the format "版本vX.X.X(Y)".
- Replaced hardcoded version string with dynamic bundle reading
- Added computed property to format version and build information
- Ensured proper fallback values for missing bundle information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
SettingsPage.swiftto read version fromCFBundleShortVersionStringand build fromCFBundleVersionTest plan
🤖 Generated with Claude Code