Fix: Safari view UI mode and Settings page external links #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Environment property to track colorScheme in SafariView - Safari view controller now inherits interface style from root view controller - Properly handles system, light, and dark appearance modes - Sets appropriate tint colors based on effective UI style 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replaced WebBrowserView and SafariWebView with direct SafariView usage - Added IdentifiableURL wrapper to support sheet presentation - Eliminated empty intermediate pages when opening external links - All external links now open in SafariView with proper UI mode support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Safari view appearance to respect the app's UI mode settings and streamlines external link handling in the Settings page by removing intermediate views.
- Safari view now properly inherits and applies the current UI mode (light/dark/system)
- Settings page external links use direct SafariView presentation instead of intermediate web views
- Eliminated empty pages that appeared when opening external links
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| V2er/View/Settings/SettingsPage.swift | Replaced web view components with direct SafariView usage and added IdentifiableURL wrapper for sheet presentation |
| V2er/General/Extentions.swift | Enhanced SafariView to track color scheme and apply appropriate UI styles and tint colors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+309
to
+317
| if effectiveStyle { | ||
| // Dark mode colors | ||
| safariVC.preferredControlTintColor = UIColor.systemBlue | ||
| safariVC.preferredBarTintColor = UIColor.systemBackground | ||
| } else { | ||
| // Light mode colors | ||
| safariVC.preferredControlTintColor = UIColor.systemBlue | ||
| safariVC.preferredBarTintColor = UIColor.systemBackground | ||
| } |
There was a problem hiding this comment.
The tint color configuration is identical for both dark and light modes. This duplicated logic should be extracted outside the conditional or the conditional should be removed entirely since both branches set the same values.
Suggested change
| if effectiveStyle { | |
| // Dark mode colors | |
| safariVC.preferredControlTintColor = UIColor.systemBlue | |
| safariVC.preferredBarTintColor = UIColor.systemBackground | |
| } else { | |
| // Light mode colors | |
| safariVC.preferredControlTintColor = UIColor.systemBlue | |
| safariVC.preferredBarTintColor = UIColor.systemBackground | |
| } | |
| // Tint color configuration is identical for both dark and light modes | |
| safariVC.preferredControlTintColor = UIColor.systemBlue | |
| safariVC.preferredBarTintColor = UIColor.systemBackground |
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Safari View UI Mode Support
@Environment(\.colorScheme)to track current color schemeSettings Page External Links
Test Plan
🤖 Generated with Claude Code