Skip to content

feat: Add comprehensive dark mode support #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

graycreate
Copy link
Member

Summary

  • Implemented comprehensive dark mode support with adaptive color system
  • Added 15 new semantic color assets for light/dark mode compatibility
  • Updated key views and components to use adaptive colors

Changes

  • Created semantic color assets in Assets.xcassets for all UI elements
  • Enhanced Color.swift with new adaptive color definitions
  • Added appearance settings with system/light/dark mode options
  • Updated critical views to use adaptive colors:
    • Login page
    • User profile views
    • Tag detail page
    • Section items and tab bar
    • Toast notifications
    • Rich text webviews

Test plan

  • Test app in light mode
  • Test app in dark mode
  • Test automatic mode switching based on system preference
  • Verify all views display correctly in both modes
  • Check color contrast and readability

🤖 Generated with Claude Code

graycreate and others added 2 commits July 12, 2025 19:50
Updated UserDetailPage, TagDetailPage, and Webview to use adaptive colors:
- Replaced hardcoded .white with Color.primaryText/itemBackground
- Replaced .black with Color.primaryText
- Replaced .gray with Color.secondaryText
- Updated CSS colors in Webview for proper dark mode support
- Adjusted overlay opacity for better visibility in both themes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Remove UIUserInterfaceStyle restriction from Info.plist to allow system theme
- Create adaptive color system with light/dark variants for all UI elements
- Add 15 new color sets with proper dark mode support
- Implement appearance settings with light/dark/system options
- Update main app to apply user's color scheme preference
- Add appearance toggle in settings page with Chinese localization
- Update key views to use adaptive colors instead of hardcoded values
- Fix navigation bar appearance to adapt to dark mode
- Add @retroactive attribute to fix UINavigationController extension warning
- Make color properties public to fix accessibility issues

This enables full dark mode support throughout the app, automatically
adapting to system preferences or user's manual selection.

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

Code Coverage Report ❌

Current coverage: 0%

@graycreate graycreate closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant