-
Notifications
You must be signed in to change notification settings - Fork 46
fix: restore adaptive icon support removed in PR #147 #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4610789
fix: restore adaptive icon support removed in PR #147
graycreate 36b0465
fix: use color resource for adaptive icon foreground
graycreate 9220666
fix: use new logo design for adaptive icon with proper structure
graycreate 78cefca
fix: improve adaptive icon visibility and scaling
graycreate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="108dp" | ||
| android:height="108dp" | ||
| android:viewportWidth="108" | ||
| android:viewportHeight="108"> | ||
| <group | ||
| android:scaleX="0.3" | ||
| android:scaleY="0.3" | ||
| android:translateX="21.6" | ||
| android:translateY="21.6"> | ||
| <path | ||
| android:pathData="M480.859,520.767C486.88,504.294 483.548,489.658 473.18,476.663C451.429,449.4 429.349,422.4 407.406,395.29C370.115,349.215 332.857,303.113 295.504,257.088C289.433,249.607 286.667,241.349 288.655,231.887C291.203,219.755 301.661,211.145 314.474,211.122C377.739,211 441.006,210.872 504.27,211.25C519.537,211.341 531.854,218.846 541.463,230.737C578.15,276.134 614.877,321.499 651.591,366.874C674.322,394.968 697.004,423.1 719.804,451.138C745.329,482.526 745.544,526.965 719.577,561.007C698.98,588.011 677.793,614.566 656.783,641.254C619.791,688.242 582.734,735.179 545.705,782.138C545.481,782.422 545.252,782.704 545.058,783.008C530.88,805.232 510.818,813.54 484.414,812.973C428.043,811.763 371.628,812.573 315.231,812.615C308.17,812.621 301.574,811.212 295.753,807.12C282.386,797.721 280.036,780.463 290.691,765.962C299.673,753.736 309.315,741.993 318.702,730.065C370.103,664.748 421.516,599.44 472.922,534.126C476.065,530.134 478.821,525.907 480.859,520.767Z" | ||
| android:fillColor="#000000" /> | ||
| </group> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="108dp" | ||
| android:height="108dp" | ||
| android:viewportWidth="108" | ||
| android:viewportHeight="108"> | ||
| <group | ||
| android:scaleX="0.3" | ||
| android:scaleY="0.3" | ||
| android:translateX="21.6" | ||
| android:translateY="21.6"> | ||
| <path | ||
| android:pathData="M480.859,520.767C486.88,504.294 483.548,489.658 473.18,476.663C451.429,449.4 429.349,422.4 407.406,395.29C370.115,349.215 332.857,303.113 295.504,257.088C289.433,249.607 286.667,241.349 288.655,231.887C291.203,219.755 301.661,211.145 314.474,211.122C377.739,211 441.006,210.872 504.27,211.25C519.537,211.341 531.854,218.846 541.463,230.737C578.15,276.134 614.877,321.499 651.591,366.874C674.322,394.968 697.004,423.1 719.804,451.138C745.329,482.526 745.544,526.965 719.577,561.007C698.98,588.011 677.793,614.566 656.783,641.254C619.791,688.242 582.734,735.179 545.705,782.138C545.481,782.422 545.252,782.704 545.058,783.008C530.88,805.232 510.818,813.54 484.414,812.973C428.043,811.763 371.628,812.573 315.231,812.615C308.17,812.621 301.574,811.212 295.753,807.12C282.386,797.721 280.036,780.463 290.691,765.962C299.673,753.736 309.315,741.993 318.702,730.065C370.103,664.748 421.516,599.44 472.922,534.126C476.065,530.134 478.821,525.907 480.859,520.767Z" | ||
| android:fillColor="#000000" /> | ||
| </group> | ||
| </vector> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@color/ic_launcher_background" /> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground" /> | ||
| <monochrome android:drawable="@drawable/ic_launcher_monochrome" /> | ||
| </adaptive-icon> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@color/ic_launcher_background" /> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground" /> | ||
| <monochrome android:drawable="@drawable/ic_launcher_monochrome" /> | ||
|
Comment on lines
+2
to
+5
|
||
| </adaptive-icon> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same scaling/translation issue as foreground drawable; the monochrome path will also be clipped outside the viewport. Align its scale/position with corrected foreground values to ensure consistent themed icon rendering.