Support ifc format #61
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
|
or switch to a different loader that doesn't require eval... |
|
I managed to temporarily hack the CSP rules to move forward, and now the next error: |
I wouldn't add configuration for each loader. Instead I'd add a setting to enable/disable all loaders that e.g. require eval or any other kind of additional configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Update three JS to 0.139.2 #59 to be merged first to get latest three JS
loader is not working due to unsafe-eval:
I'm wondering if we should allow to disable loaders in the configuration, this way if someone is not using formats like IFC they could disable it and bypass the security concerns.