Skip to content

Commit

Permalink
Migrating issue generation to breeze release-management (apache#38062)
Browse files Browse the repository at this point in the history
LGTM.  Having the dynamic versions is for the follow up :)
  • Loading branch information
amoghrajesh authored Mar 16, 2024
1 parent e9d3232 commit 8660eef
Show file tree
Hide file tree
Showing 19 changed files with 831 additions and 409 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/check-providers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ jobs:
run: >
breeze release-management generate-issue-content-providers
--only-available-in-dist --disable-progress
- name: "Test airflow core issue generation automatically"
run: >
breeze release-management generate-issue-content-core
--previous-release 1.9.0 --current-release 1.10.0
- name: "Generate source constraints from CI image"
shell: bash
run: >
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/helm-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ jobs:
run: ./dev/sign.sh dist/airflow-*.tgz dist/airflow-*-source.tar.gz
env:
SIGN_WITH: dev@airflow.apache.org
- name: "Test helm chart issue generation automatically"
# Adding same tags for now, will address in a follow-up
run: >
breeze release-management generate-issue-content-helm-chart
--previous-release helm-chart/0.0.0dev0 --current-release helm-chart/0.0.0dev0
- name: "Upload Helm artifacts"
uses: actions/upload-artifact@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion dev/README_RELEASE_AIRFLOW.md
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,8 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
git pull # Ensure that the script is up-to-date
breeze release-management start-rc-process --version ${VERSION} --previous-version <PREVIOUS_VERSION>
# Create issue for testing the RC
./dev/prepare_release_issue.py generate-issue-content --previous-release <PREVIOUS_VERSION> --current-release ${VERSION}
breeze release-management generate-issue-content-core --previous-release <PREVIOUS_VERSION>
--current-release ${VERSION}
```

## Prepare production Docker Image RC
Expand Down
5 changes: 2 additions & 3 deletions dev/README_RELEASE_HELM_CHART.md
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,8 @@ EOF
Content is generated with:

```shell
./dev/prepare_release_issue.py generate-issue-content --previous-release helm-chart/<PREVIOUS_RELEASE> \
--current-release helm-chart/${VERSION}${VERSION_SUFFIX} --is-helm-chart
breeze release-management generate-issue-content-helm-chart
--previous-release helm-chart/<PREVIOUS_RELEASE> --current-release helm-chart/${VERSION}${VERSION_SUFFIX}
```

Copy the URL of the issue.
Expand Down
20 changes: 20 additions & 0 deletions dev/breeze/doc/09_release_management_tasks.rst
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,16 @@ When we prepare final release, we automate some of the steps we need to do.
:width: 100%
:alt: Breeze release-management start-rc-process

Generating airflow core Issue
"""""""""""""""""""""""""

You can use Breeze to generate a airflow core issue when you release new airflow.

.. image:: ./images/output_release-management_generate-issue-content-providers.svg
:target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/doc/images/output_release-management_generate-issue-content-core.svg
:width: 100%
:alt: Breeze generate-issue-content-core


Preparing Python Clients
""""""""""""""""""""""""
Expand Down Expand Up @@ -227,6 +237,16 @@ This prepares helm chart .tar.gz package in the dist folder.
:width: 100%
:alt: Breeze release-management prepare-helm-chart-package

Generating helm chart Issue
"""""""""""""""""""""""""

You can use Breeze to generate a helm chart issue when you release new helm chart.

.. image:: ./images/output_release-management_generate-issue-content-providers.svg
:target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/doc/images/output_release-management_generate-issue-content-helm-chart.svg
:width: 100%
:alt: Breeze generate-issue-content-helm-chart


Provider release commands
.........................
Expand Down
68 changes: 38 additions & 30 deletions dev/breeze/doc/images/output_release-management.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_release-management.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7e7d82328d7a6d8862d663b4a0a25767
614db2f2ce8287fc9f2b44777aa31162
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8e911f09e161d4fff654119656017be6
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
66451b1e0d4897113e3763e04d73b65e
50 changes: 27 additions & 23 deletions dev/breeze/doc/images/output_setup_check-all-params-in-groups.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c460ad112eb9edf1a3bf7246b024dfcc
b6ce88cfe1053d75612a84eef25b49ae
58 changes: 33 additions & 25 deletions dev/breeze/doc/images/output_setup_regenerate-command-images.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0ae4af7ff2065325e7442c444a83d8e3
76b6c13c962c16869a3ffc8e535ae37e
36 changes: 36 additions & 0 deletions dev/breeze/src/airflow_breeze/commands/ISSUE_TEMPLATE.md.jinja2
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{#
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-#}

We are kindly requesting that contributors to [{{link_text}}]({{link}}) help test the RC.

Please let us know by commenting if the issue is addressed in the latest RC.

{% for pr_number in pr_list %}
{%- set pr = pull_requests[pr_number] -%}
- [ ] [{{ pr.title }} (#{{ pr.number }})]({{ pr.html_url }}): {{ user_logins[pr_number] }}
{%- if linked_issues[pr_number] %}
Linked issues:
{%- for linked_issue in linked_issues[pr_number] %}
- [{{ linked_issue.title }} (#{{ linked_issue.number }})]({{ linked_issue.html_url }})
{%- endfor %}
{%- endif %}
{% endfor %}

Thanks to all who contributed to the release (probably not a complete list!):
{{ all_user_logins }}
Loading

0 comments on commit 8660eef

Please sign in to comment.