Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes enableOnReadOnly bug when datepicker is of type component #1684

Closed
wants to merge 1 commit into from
Closed

Fixes enableOnReadOnly bug when datepicker is of type component #1684

wants to merge 1 commit into from

Conversation

jonssonth
Copy link
Contributor

No description provided.

@acrobat
Copy link
Member

acrobat commented Nov 23, 2015

Hi @gabriel, thanks for this patch! Can you provide a jsfiddle example to show the current bug?

@jonssonth
Copy link
Contributor Author

@acrobat sure, here it is: https://jsfiddle.net/c1tc6ztq/10/

@acrobat acrobat added this to the 1.5.1 milestone Dec 8, 2015
@acrobat
Copy link
Member

acrobat commented Dec 8, 2015

Thanks @jonssonth!

@acrobat acrobat closed this in b68ae12 Dec 8, 2015
@acrobat acrobat mentioned this pull request Dec 8, 2015
Closed
@vsn4ik
Copy link
Member

vsn4ik commented Dec 9, 2015

Test cases?

@acrobat
Copy link
Member

acrobat commented Dec 9, 2015

Hmm yes indeed I forgot to ask.. @jonssonth can you provide a test for this fix?

@jonssonth
Copy link
Contributor Author

@acrobat i'll fix the test.

@acrobat
Copy link
Member

acrobat commented Jan 30, 2016

Ok great, just create a separate pr for the missing tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-needs-test
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jonssonth @acrobat @vsn4ik