Data-API support for component, disabled and readonly #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Data-API support for component. Currently, Data-API covers only the input itself, but not the add-on/input-group-addon. This PR detect the addon, and listen the click on it, exactly as the input, without any JS to be written. In addition, disable and readonly states are managed.
|
@fabdouglas please check the failing test suite! Do we need to add some extra tests to check this behavior? |
|
In fact the expected feature is already implemented in a different way but not clearly documented. I've added a PR for the doc in #1674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Data-API support for component. Currently, Data-API covers only the input itself, but not the add-on/input-group-addon.
This PR detect the addon, and listen the click on it, exactly as the input, without any JS to be written.
In addition, disable and readonly states are managed.