Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmatched pragma warning push/pop #996

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

Chronial
Copy link
Contributor

This is a rather severe issue, as it can break user code in surprising ways:

#pragma warning(push)
#pragma warning(disable: ....)
#include <tbb/parallel_for_each.h>
#pragma warning(pop)

// Warnings are still disabled

Type of change

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

dnmokhov
dnmokhov previously approved these changes Dec 21, 2022
Copy link
Contributor

@dnmokhov dnmokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kboyarinov
kboyarinov previously approved these changes Jan 2, 2023
@kboyarinov
Copy link
Contributor

@Chronial, thank you very much for the contribution.
Could you please sign the commit before merging this as described here.

@Chronial
Copy link
Contributor Author

Chronial commented Jan 2, 2023

done

kboyarinov
kboyarinov previously approved these changes Jan 2, 2023
@kboyarinov
Copy link
Contributor

@Chronial, the last request from my side. As you may see, copyright scan has failed and the copyright notice in the file you changed should be updated to 2023.

Signed-off-by: Christian Fersch <christian.fersch@ptvgroup.com>
@Chronial
Copy link
Contributor Author

Chronial commented Jan 2, 2023

done

@kboyarinov kboyarinov merged commit e6e493f into uxlfoundation:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants