Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] task_group_dynamic_dependencies #1469

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
18ad843
Removed deprecated as cause for archive
vossmjp Aug 5, 2024
5404632
Added task_group_dynamic_dependencies RFC
vossmjp Aug 5, 2024
e1b964a
Addressed several comments on RFC
vossmjp Oct 1, 2024
416d638
Updated add_dependency figure
vossmjp Oct 1, 2024
66710d2
Updated naming in task_group_dynamic_dependencies RFC and added more …
vossmjp Oct 1, 2024
1b32c34
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Dec 4, 2024
aceddbd
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Dec 4, 2024
19ac8d8
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Dec 4, 2024
ff7e366
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Dec 4, 2024
11b26d6
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 9, 2025
5a27a6c
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 30, 2025
97ef660
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 30, 2025
83eec0f
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 30, 2025
cbacc32
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 30, 2025
9681b66
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 30, 2025
304faf1
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
vossmjp Jan 30, 2025
746ef99
Response to reviews
vossmjp Jan 30, 2025
f69b18c
Response to reviews
vossmjp Jan 30, 2025
c373fbb
Additional wording changes for dynamic tasks RFC
vossmjp Jan 31, 2025
d2432ab
Apply suggestions from code review
vossmjp Jan 31, 2025
9b433be
Apply suggestions from code review
vossmjp Jan 31, 2025
bc78aca
Apply suggestions from code review
vossmjp Jan 31, 2025
91deaf2
Changes to address reviews
vossmjp Jan 31, 2025
eeb66ba
Addressed API comments for dynamic task API RFC
vossmjp Jan 31, 2025
3884430
Clarified what a valid task_handle can represent
vossmjp Jan 31, 2025
52bb751
Apply suggestions from code review
vossmjp Feb 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update rfcs/proposed/task_group_dynamic_dependencies/README.md
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
  • Loading branch information
vossmjp and aleksei-fedotov committed Dec 4, 2024
commit 1b32c348a878cce42e20f3940b9fc80dd8ddd893
2 changes: 1 addition & 1 deletion rfcs/proposed/task_group_dynamic_dependencies/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ The first extension is to expand the semantics and usable lifetime of
`task_handle` so that remains valid after it is passed to run and it can
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
represent tasks in any state, including submitted, executing, and completed
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
tasks. Similarly, a `task_handle` in the submitted state may represent a task
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
that has predecessors that must complete before it can executed, and so passing
that has predecessors that must complete before it can execute, and so passing
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
a `task_handle` to `task_group::run` or `task_group::run_and_wait` only makes
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
it available for dependency tracking, and does not make it immediately legal to
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
execute.
vossmjp marked this conversation as resolved.
Show resolved Hide resolved
Expand Down