Skip to content

Comments

[BLAS] Add BLAS ARM performance libraries backend.#629

Merged
Rbiessy merged 7 commits intouxlfoundation:developfrom
SiPearl:ad/armpl_blas_backend
Jan 31, 2025
Merged

[BLAS] Add BLAS ARM performance libraries backend.#629
Rbiessy merged 7 commits intouxlfoundation:developfrom
SiPearl:ad/armpl_blas_backend

Conversation

@adegomme
Copy link
Contributor

Description

This adds the support for aarch64 CPUs using ARM performance libraries backend, with BLAS domain for now (LAPACK to come later).
Support for most functions is native, some batch ones are implemented directly.
It also enables NETLIB backend on aarch64 CPUs.

  • Do all unit tests pass locally?
    This has been tested on Neoverse N1, V1, V2 CPUs, with dpcpp compiler and pocl backend.
    100% tests passed, 0 tests failed out of 1960
    128 tests are skipped, due to unimplemented omatadd/copy, batch or int8/bfloat16 unsupported features.
    AdaptiveCpp also has been tested to compile and run.
    log.txt

Signed-off-by: Augustin Degomme <augustin.degomme@sipearl.com>
Co-authored-by: Nicolas Bouton <nicolas.bouton@sipearl.com>
Co-authored-by: Romain Dolbeau <romain.dolbeau@sipearl.com>
@adegomme adegomme requested review from a team as code owners January 28, 2025 10:59
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! I have a few initial comments/questions.

Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just to double-check: you have tested both the Netlib backend and the Arm Performance Libraries backend on ARM hardware?

@adegomme
Copy link
Contributor Author

Looks good! Just to double-check: you have tested both the Netlib backend and the Arm Performance Libraries backend on ARM hardware?

Indeed, see log attached for the netlib one (on an ARM neoverse v2 platform)
log_netlib.txt
(more tests are skipped as there are more unimplemented calls)

@dnhsieh-intel
Copy link
Contributor

It looks like some tables are off:

image

image

Please update the tables. Thanks!

@adegomme
Copy link
Contributor Author

adegomme commented Jan 29, 2025

It looks like some tables are off:

Please update the tables. Thanks!

good catch, it shoud be fixed now. Thanks!

@dnhsieh-intel
Copy link
Contributor

By the way, I only spotted the tables by chance. The PR can be merged without my approval.

@Rbiessy Rbiessy merged commit af66e5e into uxlfoundation:develop Jan 31, 2025
9 checks passed
@Rbiessy Rbiessy mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants