[SPARSE] Add support for sparse GEMM using MKLCPU#403
[SPARSE] Add support for sparse GEMM using MKLCPU#403Rbiessy merged 10 commits intouxlfoundation:developfrom Rbiessy:romain/sparse_gemm
Conversation
|
Log using a recent close-source MKL and DPCPP builds, all tests are passing: sparse_gemm_log.txt |
|
I have rebased the branch and confirmed that this is still building and running fine with oneapi 2023.2.0 as well as with recent DPCPP + MKL builds (see log above). |
|
This PR looks good to me! I mostly had questions for my own sake. |
Co-authored-by: noffermans <126679373+noffermans@users.noreply.github.com>
Co-authored-by: noffermans <126679373+noffermans@users.noreply.github.com>
FMarno
left a comment
There was a problem hiding this comment.
I think it looks good overall. Feel free to ignore my comment.
gajanan-choudhary
left a comment
There was a problem hiding this comment.
Once you add the second optimize_gemm() API, I will approve. Overall the changes look fine.
I just need to take a closer look at the gemm unit test to understand ldb/ldc/inner dim/outer dim, etc. and the combinations that play out in there, but that is not a blocker for the PR.
Co-authored-by: noffermans <126679373+noffermans@users.noreply.github.com>
Description
Add support for sparse GEMM using MKLCPU.
This relies on #402 and #374
Checklist
All Submissions
New features