[tests] skip DP tests on devices without DP support#395
[tests] skip DP tests on devices without DP support#395mkrainiuk merged 6 commits intouxlfoundation:developfrom
Conversation
mmeterel
left a comment
There was a problem hiding this comment.
Thanks for the PR. Would it be possible to add a macro for the check and use it everywhere? It would make it easier if we need to update it later.
This is a good idea, I will update the tests. |
mmeterel
left a comment
There was a problem hiding this comment.
Thanks for the update. Looks good to me.
|
The DFT tests can also use double precision, should we add the same kind of checks there in this PR? Last time I checked the CI is running very few DFT tests for the GPU device but I don't know why. |
As I see DFT already has the check for DP support on the device during commit stage https://github.com/oneapi-src/oneMKL/blob/develop/tests/unit_tests/dft/source/descriptor_tests.cpp#L599-L601 |
Indeed, I missed that, thanks! |
Co-authored-by: Romain Biessy <romain.biessy@codeplay.com>
Co-authored-by: Romain Biessy <romain.biessy@codeplay.com>
Description
PR adds double precision support check to unit tests for skipping double precision tests on devices that do not support it.
I've tested the changes on Intel Arc A770, all double precision tests are skipped as expected, all other tests are passed except for
GemmBatchUsmfor half precision (not related to the changes).Checklist
All Submissions