[DFT] Add rocFFT backend for DFT interface#330
Merged
FMarno merged 10 commits intouxlfoundation:developfrom Jun 22, 2023
Merged
[DFT] Add rocFFT backend for DFT interface#330FMarno merged 10 commits intouxlfoundation:developfrom
FMarno merged 10 commits intouxlfoundation:developfrom
Conversation
Contributor
Author
|
Things to do:
|
FMarno
commented
Jun 6, 2023
Rbiessy
reviewed
Jun 8, 2023
Rbiessy
approved these changes
Jun 8, 2023
Contributor
Author
|
Test run log - rocfft_run.log |
hjabird
reviewed
Jun 12, 2023
Contributor
hjabird
left a comment
hjabird
left a comment
There was a problem hiding this comment.
Looks good on the whole!
Rbiessy
approved these changes
Jun 14, 2023
| }); | ||
| // Heuristic for the average-case error margins | ||
| abs_error_margin = | ||
| std::abs(max_norm_ref) * std::log2(static_cast<double>(forward_elements)); |
Contributor
There was a problem hiding this comment.
can you explain this change ?
Contributor
Author
There was a problem hiding this comment.
The tests were failing and this was a way I found to make them pass. I can't really do much about increasing the accuracy of the rocfft results.
FMarno
commented
Jun 22, 2023
anantsrivastava30
approved these changes
Jun 22, 2023
Contributor
anantsrivastava30
left a comment
anantsrivastava30
left a comment
There was a problem hiding this comment.
The implimentation looks good to me in regards to plan creating syncronization and execution interleaved and planner, all tests are passing and has good spec coverage. approved
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
* Add rocfft backend * avoid creating plans with invalid strides * update example * Update readme to show rocfft support * Update product and version information * increase tolerances * update README * formatting changes * fix unique_ptr creation * Apply rule of three to rocfft commit class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add rocFFT as a backend for the DFT interface, allowing use of the DFT interface with AMD GPUs.
There is a bit of a issue with
rocfft_setup/rocfft_cleanup. These both affect the global state, so if the user was also using rocfft (unlikely), they could potentially cause a "double" setup/cleanup.Fixes #27
Checklist
All Submissions