Fix invalid trademarks #3062
Merged
Fix invalid trademarks #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
Vika-F
requested review from
Alexsandruss,
samir-nasibli and
Alexandr-Solovev
as code owners
Vika-F
requested review from
ethanglaser and
KateBlueSky
and removed request for
samir-nasibli
ethanglaser
reviewed
Feb 5, 2025
| @@ -186,7 +187,7 @@ class mpi_communicator_impl : public via_host_interface_selector<MemoryAccessKin | |||
| return (major >= 2021); | |||
| } | |||
|
|
|||
| // Return status of MPI ze support using pointer to function | |||
| // Return status of Intel(R) MPI Library ze support using pointer to function | |||
There was a problem hiding this comment.
This one can be left as the original - this part is not specific to Intel MPI
ethanglaser
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Illegal trademarks are fixed:
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
The changes are made only in the comments. That's why most of the check boxes are not relevant and were removed.