Initial input for backend selection #2396

amgrigoriev · 2023-05-30T13:11:20Z

Description

Single entry for backend selection
Some reference implementations to replace MKL (naive ones)
makefile changes - BACKEND_CONFIG was added with two possible options: "mkl" or "ref"
bazel build system changes to reflect ref implementation
CI for x86 openBLAS build

cpp/daal/src/algorithms/service_kernel_math.h

cpp/daal/src/externals/config_template.h

cpp/daal/src/externals/service_blas_ref.h

cpp/daal/src/externals/service_lapack_declar_ref.h

cpp/daal/src/externals/service_math_ref.h

cpp/daal/src/externals/service_service_ref.h

cpp/daal/src/externals/service_spblas_ref.h

dev/make/cmplr.gnu.mkl.mk

dev/make/cmplr.gnu.ref.mk

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

…amgrigoriev/daal into dev/agrigorev-backend-selection

dev/make/cmplr.gnu.mkl.mk

dev/make/cmplr.gnu.ref.mk

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

dev/make/cmplr.clang.ref.mk

dev/make/deps.mkl.mk

…amgrigoriev/daal into dev/agrigorev-backend-selection

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

rakshithgb-fujitsu · 2023-06-12T11:05:07Z

This PR fails when mkl is used as backend. I get many such errors:

./cpp/daal/src/externals/service_math_mkl.h:146:69: error: use of undeclared identifier 'fpk_vml_dExp_L9HAynn'

Command used:

make -f makefile daal oneapi_c BACKEND_CONFIG=mkl PLAT=lnx32e COMPILER=clang -j16

napetrov · 2023-06-13T09:11:09Z

dev/make/cmplr.clang.ref.mk

+COMPILER.mac.clang = clang++ -m64 -fgnu-runtime -stdlib=libc++ -mmacosx-version-min=10.15 -fwrapv \
+                     -DDAAL_REF -Werror -Wreturn-type
+COMPILER.lnx.clang = clang++ -m64 \
+                     -DDAAL_REF -Werror -Wreturn-type


As far the only difference between mkl and ref mk files is -DDAAL_REF definition - would it be worth putting it's definition to main makefile instead of copying mkl and ref makefiles? So this would reduce code duplication here

Even with future architectures march targets, they can be put within same files

The problem is that X86 is the simplest case where it is possible to use simple solutions. In general (having cross-compilation in mind), it is necessary to add the following:

--target=...

--gcc-toolchain=...

--sysroot=...

-march=...

-mabi=...

-mtune=...
I guess it is better to separate every such compiler settings in its own file

cpp/daal/src/externals/config_template.h

napetrov · 2023-06-14T08:57:42Z

/intelci: run

napetrov · 2023-06-14T13:07:11Z

There are also formatting hits
+---+---+---+---+---+---+---+---+------
|NLS|TAB|CHR|TAL|EOF|150|EXT|CRT| NAME
+---+---+---+---+---+---+---+---+------
| U | o | o | o | X | o | o | X | cpp/daal/src/algorithms/kernel_config.h
| U | o | o | o | o | o | o | X | cpp/daal/src/externals/config_ref.h
| U | o | o | o | X | o | o | X | cpp/daal/src/externals/config_template.h
| U | o | o | o | o | o | o | X | cpp/daal/src/externals/service_service_ref.h

EOF ==> not exactly one newline before EOF
CTR ==> wrong name of file before copyright notice

rakshithgb-fujitsu · 2023-06-21T06:42:29Z

Performance issues, this PR with ref as backend fails to run with multithreading, every algorithm seems to use only single thread. Is anything disabled in this path or could it be issues with OpenBLAS? mkl backend works fine (uses multithreading) and matches the performance of master.

KulikovNikita · 2023-06-21T07:44:26Z

Performance issues, this PR with ref as backend fails to run with multithreading, every algorithm seems to use only single thread. Is anything disabled in this path or could it be issues with OpenBLAS? mkl backend works fine (uses multithreading) and matches the performance of master.

It can probably be related to this lines of the code:

        int old_threads = openblas_get_num_threads();
        openblas_set_num_threads(1);
        ...
        openblas_set_num_threads(old_threads);

I suspect that it changes the global state of OpenMP and for some reason forces it to run on a specific thread despite what TBB thread assigns it to.

I suspect that we should be able to build it without affinity: https://github.com/xianyi/OpenBLAS/blob/develop/USAGE.md#how-could-i-disable-openblas-threading-affinity-on-runtime

.ci/env/openblas.sh

amgrigoriev · 2023-08-22T11:25:46Z

/intelci: run

napetrov · 2023-08-22T11:29:08Z

/intelci: run

napetrov

Just blocking merge as safety measure until win build warnings would be fixed.

napetrov · 2023-08-22T11:40:59Z

So, on warning fixes
plan A check on results of dropping IPP from FPK
plan B on Java removal - #2469

napetrov · 2023-08-23T12:54:25Z

/intelci: run

napetrov · 2023-08-23T16:08:40Z

/intelci: run

KulikovNikita · 2023-08-24T13:46:52Z

/intelci: run

napetrov · 2023-08-24T14:05:39Z

FPK update didn't help - duplication happens even without IPP lib

amgrigoriev · 2023-08-24T14:42:28Z

Could you expose the warning?

amgrigoriev · 2023-08-24T15:22:16Z

Is this that one: daal_vmlipp_core.lib(vml_dLog1p_L9HAynn.obj) : warning LNK4006: fpk_vml_dLog1pI_L9HAynn already defined in daal_mkl_thread.lib(vml_dLog1p_L9HAynn.obj)? I am wondering if another library contains duplicated symbols after IPP removal?

napetrov · 2023-08-24T15:26:51Z

Is this that one: daal_vmlipp_core.lib(vml_dLog1p_L9HAynn.obj) : warning LNK4006: fpk_vml_dLog1pI_L9HAynn already defined in daal_mkl_thread.lib(vml_dLog1p_L9HAynn.obj)? I am wondering if another library contains duplicated symbols after IPP removal?

daal_vmlipp_core.lib(mkl_support.obj) : warning LNK4006: fpk_serv_strcat2 already defined in daal_mkl_thread.lib(mkl_support.obj); second definition ignored

It's same obj as it still contain vml/vsl part although ipp was removed. Now there is 2100 warning lines vs 2500 with previous FPK. All warnings are only happen for vml/vsl functions now.

napetrov · 2023-08-25T08:24:36Z

/intelci: run

napetrov · 2023-08-25T09:17:27Z

@amgrigoriev - thank you for fix. Warnings are gone now. Waiting for CI checks to finish

napetrov

Thanks to everyone involved!

* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build #2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <a.grigorev@yadro.com> Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> Co-authored-by: a.maklaev <a.maklae@yadro.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> Co-authored-by: Pavel Yakovlev <p.yakovlev@yadro.com>

Alexsandruss · 2023-08-25T17:40:46Z

@amgrigoriev, this PR reverted #2392. Are you sure there are no additional rebasing mistakes in PR?

napetrov · 2023-08-25T21:04:47Z

at least this one - Revert "Fixed copying performance issues (#2375)" #2390

* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build uxlfoundation#2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <a.grigorev@yadro.com> Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> Co-authored-by: a.maklaev <a.maklae@yadro.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> Co-authored-by: Pavel Yakovlev <p.yakovlev@yadro.com>

* Fix incorrect include in service_hash_table.h file * Add initial implementation of the base algorithm::Hyperparameter class * clang-format * Add Hyperparameter* _hpar field into base Algorithm and AlgorithmContainer classes * Implement initial version of Hyperparameters class for Covariance algorithm in DAAL * Extend covariance::BatchImpl (and thus covariance::Batch) interface with the Hyperparameter support * Remove outdated verionst of setArgument methods * Add ability to pass hyperparameters from DAAL API to kernels in Covariance algorithm * 1. Make the hyperparameter field of DAAL Algorithm class constant. 2. Implement passing hyperparameters from oneDAL to DAAL on CPU * Fix * Fix Java build * Move covariance::Hyperparameter class to covariance::internal namespace * Removal of compression functionality (#2462) * Temporary disabling gemv test (#2463) * AVX/SSSE3/AVX512_MIC ISA cleanup (#2465) * cleanup avx512_mic * cleanup ssse3 * cleanup avx * fixing typos * fixing / typos * fixing make typos * clang format * Updating ISA in install.md * replace AVX with AVX2 for intersect * Remove mention of compression in docs (#2467) * Init addition of online interfaces in Covariance (#2455) * Add the link to oneAPI samples browser (#2470) * infra: update binary version (#2468) * update binary version * more binary version updates * Initial input for backend selection (#2396) * Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build #2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <a.grigorev@yadro.com> Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> Co-authored-by: a.maklaev <a.maklae@yadro.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> Co-authored-by: Pavel Yakovlev <p.yakovlev@yadro.com> * resolve merge conflict while rebasing in Fix incorrect include in service_hash_table.h file * Add ability to pass hyperparameters from DAAL API to kernels in Covariance algorithm * minor * update examples * clang-format * minor --------- Co-authored-by: Alexander Andreev <alexander.andreev@intel.com> Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Aleksandr Solovev <aleksandr.solovev@intel.com> Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com> Co-authored-by: amgrigoriev <majagalz@mail.ru> Co-authored-by: Aleksey Grigorev <a.grigorev@yadro.com> Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> Co-authored-by: a.maklaev <a.maklae@yadro.com> Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> Co-authored-by: Pavel Yakovlev <p.yakovlev@yadro.com> Co-authored-by: Md Shafiul Alam <md.shafiul.alam@intel.com> Co-authored-by: msa <111298646+md-shafiul-alam@users.noreply.github.com>

* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build uxlfoundation#2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <a.grigorev@yadro.com> Co-authored-by: KulikovNikita <nikita.kulikov@intel.com> Co-authored-by: a.maklaev <a.maklae@yadro.com> Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com> Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> Co-authored-by: Pavel Yakovlev <p_yak_11@mail.ru> Co-authored-by: Pavel Yakovlev <p.yakovlev@yadro.com>

Initial input for backend selection

bd08406

amgrigoriev requested review from Alexsandruss, samir-nasibli and KulikovNikita as code owners May 30, 2023 13:11

KulikovNikita reviewed May 30, 2023

View reviewed changes

cpp/daal/src/algorithms/service_kernel_math.h Outdated Show resolved Hide resolved

KulikovNikita reviewed May 30, 2023

View reviewed changes

napetrov mentioned this pull request May 30, 2023

Building scikit-learn-intelex with openblas/lapack math library with openmp uxlfoundation/scikit-learn-intelex#1294

Closed

amgrigoriev and others added 5 commits June 2, 2023 16:53

Update dev/make/cmplr.gnu.mkl.mk

32f71af

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

Update dev/make/cmplr.gnu.ref.mk

4173888

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

Merge branch 'master' into dev/agrigorev-backend-selection

3b8d239

Merge branch 'dev/agrigorev-backend-selection' of https://github.com/…

ed7ce18

…amgrigoriev/daal into dev/agrigorev-backend-selection

Changed default backend to 'mkl'

aa55677

KulikovNikita reviewed Jun 4, 2023

View reviewed changes

dev/make/cmplr.gnu.mkl.mk Outdated Show resolved Hide resolved

dev/make/cmplr.gnu.ref.mk Outdated Show resolved Hide resolved

Aleksey Grigorev and others added 4 commits June 6, 2023 10:17

Buildable onedal_c

193bb58

Added clang support

cc3b2fd

Update dev/make/cmplr.gnu.mkl.mk

18225a8

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

Update dev/make/cmplr.gnu.ref.mk

39049aa

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

KulikovNikita reviewed Jun 6, 2023

View reviewed changes

dev/make/cmplr.clang.ref.mk Outdated Show resolved Hide resolved

dev/make/deps.mkl.mk Outdated Show resolved Hide resolved

dev/make/deps.mkl.mk Outdated Show resolved Hide resolved

Aleksey Grigorev and others added 3 commits June 6, 2023 12:44

Compiler fixes for icc, icx, vc plus clang-format

a531c0f

Merge branch 'dev/agrigorev-backend-selection' of https://github.com/…

137771c

…amgrigoriev/daal into dev/agrigorev-backend-selection

Update dev/make/cmplr.clang.ref.mk

8f366b7

Co-authored-by: KulikovNikita <nikita.kulikov@intel.com>

napetrov requested a review from Vika-F June 6, 2023 10:18

rakshithgb-fujitsu mentioned this pull request Jun 13, 2023

Unable to use sklearnex after building daal4py from source uxlfoundation/scikit-learn-intelex#1329

Closed

napetrov reviewed Jun 13, 2023

View reviewed changes

cpp/daal/src/externals/config_template.h Outdated Show resolved Hide resolved

Switch to core count for blas build

243b094

napetrov reviewed Aug 21, 2023

View reviewed changes

.ci/env/openblas.sh Outdated Show resolved Hide resolved

napetrov added 3 commits August 21, 2023 17:27

Update .ci/env/openblas.sh

8fe15f0

Adding _MKL suffix for job name

2858360

Fixing daal4py job dependency

ee5458f

napetrov requested changes Aug 22, 2023

View reviewed changes

Merge branch 'master' into dev/agrigorev-backend-selection

7f127df

Aleksey Grigorev added 2 commits August 25, 2023 09:28

Merge branch 'master' into dev/agrigorev-backend-selection

d642dac

Attempt to fix warnings

31416b2

napetrov approved these changes Aug 25, 2023

View reviewed changes

napetrov merged commit ca6fdb5 into uxlfoundation:master Aug 25, 2023

ethanglaser mentioned this pull request Aug 25, 2023

infra: restore PRs 2390, 2392 #2476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial input for backend selection #2396

Initial input for backend selection #2396

amgrigoriev commented May 30, 2023 •

edited by napetrov

Loading

rakshithgb-fujitsu commented Jun 12, 2023

napetrov Jun 13, 2023

amgrigoriev Jul 11, 2023 •

edited

Loading

napetrov commented Jun 14, 2023

napetrov commented Jun 14, 2023

rakshithgb-fujitsu commented Jun 21, 2023

KulikovNikita commented Jun 21, 2023

amgrigoriev commented Aug 22, 2023

napetrov commented Aug 22, 2023

napetrov left a comment •

edited

Loading

napetrov commented Aug 22, 2023

napetrov commented Aug 23, 2023

napetrov commented Aug 23, 2023

KulikovNikita commented Aug 24, 2023

napetrov commented Aug 24, 2023

amgrigoriev commented Aug 24, 2023

amgrigoriev commented Aug 24, 2023

napetrov commented Aug 24, 2023

napetrov commented Aug 25, 2023

napetrov commented Aug 25, 2023

napetrov left a comment

Alexsandruss commented Aug 25, 2023

napetrov commented Aug 25, 2023

Initial input for backend selection #2396

Initial input for backend selection #2396

Conversation

amgrigoriev commented May 30, 2023 • edited by napetrov Loading

Description

rakshithgb-fujitsu commented Jun 12, 2023

napetrov Jun 13, 2023

Choose a reason for hiding this comment

amgrigoriev Jul 11, 2023 • edited Loading

Choose a reason for hiding this comment

napetrov commented Jun 14, 2023

napetrov commented Jun 14, 2023

rakshithgb-fujitsu commented Jun 21, 2023

KulikovNikita commented Jun 21, 2023

amgrigoriev commented Aug 22, 2023

napetrov commented Aug 22, 2023

napetrov left a comment • edited Loading

Choose a reason for hiding this comment

napetrov commented Aug 22, 2023

napetrov commented Aug 23, 2023

napetrov commented Aug 23, 2023

KulikovNikita commented Aug 24, 2023

napetrov commented Aug 24, 2023

amgrigoriev commented Aug 24, 2023

amgrigoriev commented Aug 24, 2023

napetrov commented Aug 24, 2023

napetrov commented Aug 25, 2023

napetrov commented Aug 25, 2023

napetrov left a comment

Choose a reason for hiding this comment

Alexsandruss commented Aug 25, 2023

napetrov commented Aug 25, 2023

amgrigoriev commented May 30, 2023 •

edited by napetrov

Loading

amgrigoriev Jul 11, 2023 •

edited

Loading

napetrov left a comment •

edited

Loading