Common test infrastructure + PCA tests migration #1378

rlnx · 2021-01-21T11:10:53Z

test/engine for basic test routines
- linalg module to simplify linear algebra operations
- mkl thin wrappers over MKL

…st-engine

rlnx · 2021-01-21T11:13:11Z

/intelci: run

.bazelrc

cpp/oneapi/dal/BUILD

cpp/oneapi/dal/algo/pca/BUILD

cpp/oneapi/dal/algo/pca/backend/common.hpp

cpp/oneapi/dal/algo/pca/backend/cpu/train_kernel_svd.cpp

cpp/oneapi/dal/backend/linalg/loops.hpp

cpp/oneapi/dal/backend/linalg/io.hpp

cpp/oneapi/dal/backend/linalg/matrix.hpp

…st-engine

rlnx · 2021-01-25T17:58:37Z

/intelci: run

rlnx · 2021-01-26T08:47:25Z

/intelci: run

rlnx · 2021-01-26T13:00:07Z

@napetrov, please have a look at .ci/env/oneapi.sh

rlnx · 2021-01-26T13:05:06Z

/intelci: run

rlnx · 2021-01-26T14:40:03Z

/intelci: run

napetrov · 2021-01-26T15:38:29Z

.ci/pipeline/ci.yml

      sudo apt-get update
      sudo apt-get install gcc-multilib \
                           g++-multilib \
                           binutils \
                           openjdk-11-jdk \
-                           bazel-3.4.1
+                           bazel-4.0.0


Might be good to get this regularly updated - for example via https://docs.renovatebot.com/modules/manager/regex/
This shouldn't block integraton

napetrov · 2021-01-26T15:40:33Z

@napetrov, please have a look at .ci/env/oneapi.sh

Looks good

michael-smirnov

reviewed dal/test/engine folder without sub-folders

cpp/oneapi/dal/test/engine/config.cpp

michael-smirnov · 2021-01-26T16:40:16Z

cpp/oneapi/dal/test/engine/config.cpp

 }

-void global_setup() {
+static sycl::queue get_queue(const std::string& device_selector) {


Don't we want to use filter_selector for this?
https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/ONEAPI/filter_selector.hpp#L30

https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/FilterSelector/FilterSelector.adoc

cpp/oneapi/dal/test/engine/common.hpp

cpp/oneapi/dal/test/engine/dataframe_common.hpp

cpp/oneapi/dal/test/engine/gtest_main.cpp

cpp/oneapi/dal/test/engine/macro.hpp

cpp/oneapi/dal/test/engine/math.hpp

cpp/oneapi/dal/test/engine/mocks.hpp

michael-smirnov

mkl and linalg folders reviewed

cpp/oneapi/dal/test/engine/linalg/dot.hpp

cpp/oneapi/dal/test/engine/linalg/io.hpp

cpp/oneapi/dal/test/engine/linalg/loops.hpp

cpp/oneapi/dal/test/engine/mkl/blas.hpp

cpp/oneapi/dal/test/engine/common.hpp

rlnx · 2021-01-27T20:57:33Z

/intelci: run

cpp/oneapi/dal/algo/pca/detail/train_ops.hpp

cpp/oneapi/dal/algo/pca/test/badarg.cpp

michael-smirnov · 2021-01-28T06:26:14Z

cpp/oneapi/dal/test/engine/dataframe_common.hpp

+    static table_id homogen() {
+        static_assert(dal::detail::is_floating_point<Float>());
+        if constexpr (std::is_same_v<Float, float>) {
+            return table_id{ table_kind::homogen, table_float_type::f32 };


Why you can't use homogen_table::kind() instead of creating your own enum table_kind?

https://github.com/rlnx/daal/blob/test-engine/cpp/oneapi/dal/table/homogen.hpp#L57
https://github.com/rlnx/daal/blob/test-engine/cpp/oneapi/dal/table/common.hpp#L144

I expect table::kind() and te::table_kind would diverge. For example, we could create homogen_row_major or homogen_column_major or custom table type that defined in test::engine (e.g. mock).

Arguable, but Ok, let's keep this version for now. This is probably the indicator that table::kind is useless

table::kind helps you to determine type of table at runtime, this is the main use case we discussed.

cpp/oneapi/dal/test/engine/dataframe_common.cpp

Ruslan Israfilov added 9 commits January 12, 2021 21:14

PCA tests partially migrated to new engine

d879514

Revert to Catch2

ad95825

Restore PCA batch test

3583a0f

Extend + refactor batch PCA test

9bbccb6

Handle component_count == 0 case

8254805

Merge branch 'master' of https://github.com/oneapi-src/oneDAL into te…

89c5db0

…st-engine

Update copyright

4209433

Apply clang-format

678eac7

Fix ICC build

4bb5cc0

rlnx requested review from michael-smirnov, amgrigoriev, mchernov-intel, makart19 and KulikovNikita January 21, 2021 11:10

michael-smirnov reviewed Jan 24, 2021

View reviewed changes

Ruslan Israfilov added 3 commits January 25, 2021 20:05

Move MKL and LinAlg submodules to test engine

64e2e80

Merge branch 'master' of https://github.com/oneapi-src/oneDAL into te…

4d03582

…st-engine

Bazel version update

ba27787

rlnx requested review from averbukh, outoftardis and Vika-F as code owners January 25, 2021 17:44

Ruslan Israfilov added 2 commits January 25, 2021 20:57

Move algo_fixture to fixture.hpp

b3b68b4

Fix clang-format

e7f3733

rlnx added the oneAPI Issue/PR related to oneAPI part label Jan 25, 2021

Remove unused variable

2c576c5

Ruslan Israfilov added 2 commits January 26, 2021 15:52

Download MKL in CI

dcb806f

Replace MKL package by MKL-devel

76ce094

rlnx requested a review from napetrov January 26, 2021 12:59

Ruslan Israfilov added 3 commits January 26, 2021 16:33

Update assertions

bf8c669

Namespace alias for zscore

b26ab56

Set MKLROOT in ci.yml

073d9da

napetrov reviewed Jan 26, 2021

View reviewed changes

napetrov approved these changes Jan 26, 2021

View reviewed changes

michael-smirnov reviewed Jan 26, 2021

View reviewed changes

michael-smirnov reviewed Jan 27, 2021

View reviewed changes

Fix year in copyright

0356bb0

amgrigoriev reviewed Jan 27, 2021

View reviewed changes

cpp/oneapi/dal/test/engine/common.hpp Show resolved Hide resolved

Ruslan Israfilov added 3 commits January 27, 2021 19:52

Fix @michael-smirnov findings

f4d7f7f

Fix @amgrigoriev findings

a62ba55

Fix clang-format

45478d4

michael-smirnov reviewed Jan 28, 2021

View reviewed changes

amgrigoriev reviewed Jan 28, 2021

View reviewed changes

cpp/oneapi/dal/test/engine/dataframe_common.cpp Show resolved Hide resolved

michael-smirnov approved these changes Jan 28, 2021

View reviewed changes

rlnx merged commit fe2f4fb into uxlfoundation:master Jan 28, 2021

rlnx deleted the test-engine branch March 18, 2021 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Common test infrastructure + PCA tests migration #1378

Common test infrastructure + PCA tests migration #1378

rlnx commented Jan 21, 2021 •

edited

Loading

rlnx commented Jan 21, 2021

rlnx commented Jan 25, 2021

rlnx commented Jan 26, 2021

rlnx commented Jan 26, 2021

rlnx commented Jan 26, 2021

rlnx commented Jan 26, 2021

napetrov Jan 26, 2021

napetrov commented Jan 26, 2021

michael-smirnov left a comment

michael-smirnov Jan 26, 2021

michael-smirnov Jan 26, 2021

michael-smirnov left a comment

rlnx commented Jan 27, 2021

michael-smirnov Jan 28, 2021

rlnx Jan 28, 2021

michael-smirnov Jan 28, 2021

rlnx Jan 28, 2021

Common test infrastructure + PCA tests migration #1378

Common test infrastructure + PCA tests migration #1378

Conversation

rlnx commented Jan 21, 2021 • edited Loading

rlnx commented Jan 21, 2021

rlnx commented Jan 25, 2021

rlnx commented Jan 26, 2021

rlnx commented Jan 26, 2021

rlnx commented Jan 26, 2021

rlnx commented Jan 26, 2021

napetrov Jan 26, 2021

Choose a reason for hiding this comment

napetrov commented Jan 26, 2021

michael-smirnov left a comment

Choose a reason for hiding this comment

michael-smirnov Jan 26, 2021

Choose a reason for hiding this comment

michael-smirnov Jan 26, 2021

Choose a reason for hiding this comment

michael-smirnov left a comment

Choose a reason for hiding this comment

rlnx commented Jan 27, 2021

michael-smirnov Jan 28, 2021

Choose a reason for hiding this comment

rlnx Jan 28, 2021

Choose a reason for hiding this comment

michael-smirnov Jan 28, 2021

Choose a reason for hiding this comment

rlnx Jan 28, 2021

Choose a reason for hiding this comment

rlnx commented Jan 21, 2021 •

edited

Loading