Add wildcard matching in resource counters #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'r' objects have a name with a '\\_' in the last element, things go badly, so we disallow this. This led to key pattern checks in all functions that effect registrations. Also ensure that `mreg/2' does this.
tolbrino
requested changes
Sep 17, 2020
src/gproc.erl
Outdated
| @@ -1211,10 +1220,11 @@ reg_shared1(_, _, _) -> | |||
| mreg(T, C, KVL) -> | |||
| ?CATCH_GPROC_ERROR(mreg1(T, C, KVL), [T, C, KVL]). | |||
|
|
|||
| %% TODO: We don't call valid_key/1 here, since | |||
There was a problem hiding this comment.
Sorry, a remnant from earlier.
uwiger
commented
Sep 17, 2020
Co-authored-by: Tino Breddin <tolbrino@users.noreply.github.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the edoc
rc- 'resource counter', tracks the number of resource propertieswith the same name. When the resource count reaches
0, any triggersspecified using an
on_zeroattribute may be executed (see below).If
Nameis a tuple, the last element of the name can contain awildcard, using the symbol
'\\_'. This will make the resourcecounter keep track of any resources where all elements match except
the last position. For example,
{rc,l,{a,b,'\\_'}}would keeptrack of both
{r,l,{a,b,1}}and{r,l,{a,b,2}}.