Remove trailing slash for typescript and python scrubbing directories#34
Open
matthewgeng wants to merge 4 commits intomainfrom
Open
Remove trailing slash for typescript and python scrubbing directories#34matthewgeng wants to merge 4 commits intomainfrom
matthewgeng wants to merge 4 commits intomainfrom
Conversation
sherryhli
previously approved these changes
Mar 5, 2022
Member
sherryhli
left a comment
There was a problem hiding this comment.
Looks good, but please edit the PR title to something along the lines of "Remove trailing slash in directory names"
sherryhli
approved these changes
Mar 12, 2022
Member
|
May need to bump package version to 1.0.19 depending on if #33 is merged first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
No ticket. Was originally part of fixing the RM bug, but that was moved to backlog.
Implementation description
Steps to test
What should reviewers focus on?
Checklist
package.jsonaccording to Semantic Versioning specs (semver) if I will be publishing these changes to the npm registry