add support for client provided key to messages #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekeeys
reviewed
Jan 20, 2023
|
|
||
| func (m *proximoMsg) Key() []byte { | ||
| // If no key is provided, use the message as the key, | ||
| // this is the default behaviour of substrate anyway |
There was a problem hiding this comment.
maybe the default behaviour of substrate but i think the default behaviour of samara is to use an empty key
There was a problem hiding this comment.
I was trying to keep the functionality as close to the current implementation as possible, at the moment when someone sends a message through proximo it will use the data as a key - that said if all of the backends support an empty key then I'd be happy to change it.
|
LGTM |
Nesze
approved these changes
Jan 25, 2023
jakekeeys
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for this proposal: #92
A follow up PR will need to be made to https://github.com/uw-labs/substrate to support the KeyedMessage interface in the proximo client.