Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acl support #89

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Add acl support #89

merged 8 commits into from
Aug 4, 2020

Conversation

simonhdickson
Copy link
Contributor

@simonhdickson simonhdickson commented Jul 30, 2020 •
edited
Loading

Adds support for ACL (bearer password, access rights, roles)

@simonhdickson @SpeedyCoder
Update cmd/proximo-server/main.go
3d62d71 
Co-authored-by: Michal Bock <SpeedyCoder@users.noreply.github.com>
@SpeedyCoder
Copy link
Contributor

Looks good, but I think it would be nicer to have this as one of the packages in the backend directory. That way people running customised proximo servers will be able to use it as well. In that case I would probably split the factory type into two, just to make things a bit cleaner and to match the other backends.

simonhdickson and others added 2 commits July 30, 2020 11:45
@simonhdickson @SpeedyCoder
Update cmd/proximo-server/config.go
22e8a69 
Co-authored-by: Michal Bock <SpeedyCoder@users.noreply.github.com>
@simonhdickson
Move to backend
ff0f191
SpeedyCoder
SpeedyCoder reviewed Jul 30, 2020
View reviewed changes
SpeedyCoder
SpeedyCoder reviewed Jul 30, 2020
View reviewed changes
SpeedyCoder
SpeedyCoder reviewed Jul 30, 2020
View reviewed changes
@SpeedyCoder
Copy link
Contributor

It would be good to add doc string comments to public structs and functions and add some tests as well.

SpeedyCoder
SpeedyCoder reviewed Jul 30, 2020
View reviewed changes
@jakekeeys
Copy link
Contributor

great stuff, some example config in the readme would go down a treat

@simonhdickson simonhdickson merged commit b794ca5 into master Aug 4, 2020
@simonhdickson simonhdickson deleted the add-acl-support branch August 4, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpeedyCoder SpeedyCoder SpeedyCoder approved these changes

@mjgarton mjgarton Awaiting requested review from mjgarton

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhdickson @SpeedyCoder @jakekeeys