Generated Torpedo Board Component #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartercooper
approved these changes
Sep 23, 2020
Contributor
cartercooper
left a comment
cartercooper
left a comment
There was a problem hiding this comment.
Make sure everything builds still and then you can merge this.
poornack
requested changes
Sep 24, 2020
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| static const CAN_HWConfig_S CAN_HWConfig = | ||
| { | ||
| // GPIO | ||
| .rxPin = 8, |
Contributor
There was a problem hiding this comment.
You are not using these pins for CAN in your schematic.
| static const debug_HWConfig_S debug_HWConfig = | ||
| { | ||
| // GPIO | ||
| .rxPin = 12, |
Contributor
There was a problem hiding this comment.
You are not using these pins for UART in your schematic.
|
|
||
| [MESSAGE_HANDLER_RX_CHANNEL_TESTER] = | ||
| { | ||
| .messageID = protocol_MID_MC_deviceName, |
Contributor
There was a problem hiding this comment.
This is the message ID for motor controller. Use the one for torpedo board. Create one if it doesn't exist.
| .callbackEnable = true, | ||
| .initValue = | ||
| { | ||
| .MC_deviceName = |
| { | ||
| [MESSAGE_HANDLER_TX_CHANNEL_RID] = | ||
| { | ||
| .messageID = protocol_MID_MC_deviceName, |
| { | ||
| case MESSAGE_HANDLER_TX_CHANNEL_RID: | ||
| { | ||
| memcpy(message->MC_deviceName.name, "MTR_BRD", 7U); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied motor controller 3 component and changed all the make files and etc to be torpedo board.