Linux small fixes - #300
Open
Psycast wants to merge 6 commits into
Open
Conversation
Some .wav files encountered have a data chunk between the header and format tag. This skips over data chunks until it finds the format tag. This still assumes the format tag will be before the data tag.
Add note about SDL not supporting a default filter index selection.
Iterator broke. Make beatline zoom logic consistent between both.
Use a fixed size as intended.
While hovering the last tempo help box and deleting it, drawing would attempt to access outside the bounds due to the update being between the tick() and draw() functions.
This fixes newly added items being placed before existing items in the list when on the same matching row. This also fixes a separate case when some items were not written to the merged list due to an early exit. Passes all the test files I have without any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These probably should have targeted the beta branch, but rebaseing was causing me issues.