Skip to content

Conversation

@LoukasPap
Copy link
Contributor

Fixes issue 251

Incomplete text commands (a, c, i) in POSIX mode, now result in compilation error.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.10%. Comparing base (a6207cb) to head (a4ed9c9).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   82.03%   82.10%   +0.06%     
==========================================
  Files          13       13              
  Lines        5423     5443      +20     
  Branches      291      292       +1     
==========================================
+ Hits         4449     4469      +20     
  Misses        972      972              
  Partials        2        2              
Flag Coverage Δ
macos_latest 82.54% <100.00%> (+0.06%) ⬆️
ubuntu_latest 82.66% <100.00%> (+0.06%) ⬆️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre
Copy link
Contributor

some jobs are failing
and please add high level tests

@sylvestre
Copy link
Contributor

please fix:

error: redundant clone
    --> src/sed/compiler.rs:2738:20
     |
2738 |         assert!(err.to_string().contains("incomplete command"));
     |                    ^^^^^^^^^^^^ help: remove this
     |
note: this value is dropped without further use
    --> src/sed/compiler.rs:2738:17
     |
2738 |         assert!(err.to_string().contains("incomplete command"));
     |                 ^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#redundant_clone
     = note: `-D clippy::redundant-clone` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::redundant_clone)]`

error: implicitly cloning a `String` by calling `to_string` on its dereferenced type
    --> src/sed/compiler.rs:2738:17
     |
2738 |         assert!(err.to_string().contains("incomplete command"));
     |                 ^^^^^^^^^^^^^^^ help: consider using: `err.clone()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#implicit_clone
     = note: `-D clippy::implicit-clone` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::implicit_clone)]`

error: could not compile `sed` (lib test) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

@sylvestre sylvestre merged commit 361c45e into uutils:main Feb 8, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POSIX mode incorrectly accepts incomplete i\ command

2 participants