Upgrade winnow to 0.7.10 #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Looks good mostly, but I'm concerned about the error context. Can we get that back somehow?
Contributor
Author
|
@tertsdiepraam please review this PR :) |
tertsdiepraam
approved these changes
May 19, 2025
| ctx_err.push(StrContext::Expected(StrContextValue::Description( | ||
| "timezone cannot appear more than once", | ||
| ))); | ||
| return Err(ErrMode::Backtrack(ctx_err)); |
Collaborator
There was a problem hiding this comment.
I wonder why this is marked with backtrack, but it already was so let's leave it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140.