Replace the regex parser with winnow-based parse #137
Conversation
yuankunzhang
force-pushed
the
replace-the-regex-parser
branch
3 times, most recently
from
1fbb6ec to
befe2ec
Compare
yuankunzhang
force-pushed
the
replace-the-regex-parser
branch
from
befe2ec to
bd8b226
Compare
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
I like it a lot! I've just reviewed your changes for now and I'll try to get a full review done soon. We could also just merge this and fix issues later as I think at least the structure is good.
yuankunzhang
force-pushed
the
replace-the-regex-parser
branch
from
bd8b226 to
398ed93
Compare
|
@tertsdiepraam Could I get some attention on this PR please? |
yuankunzhang
force-pushed
the
replace-the-regex-parser
branch
from
398ed93 to
333efc7
Compare
|
Thanks for reminding me! I'll put it on my todo list for tomorrow |
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Some tiny comments, but I think this should be merged soon! Well done!
yuankunzhang
force-pushed
the
replace-the-regex-parser
branch
from
333efc7 to
be56773
Compare
|
@tertsdiepraam Thanks for the review! All comments are addressed. |
yuankunzhang
force-pushed
the
replace-the-regex-parser
branch
from
be56773 to
bc6b70b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you! I'm so glad we finally got this to a mergeable state! |
4 participants
Revamp of #86.