Skip to content

install: remove todos #7872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
May 2, 2025
Merged

install: remove todos #7872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b8ae3
install: remove three todos
cakebaker May 2, 2025
937fda6
install: use map_err instead of if let Err
cakebaker May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/uu/install/src/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ pub fn uu_app() -> Command {
.action(ArgAction::SetTrue),
)
.arg(
// TODO implement flag
Arg::new(OPT_CREATE_LEADING)
.short('D')
.help(
Expand Down Expand Up @@ -274,7 +273,6 @@ pub fn uu_app() -> Command {
)
.arg(backup_control::arguments::suffix())
.arg(
// TODO implement flag
Arg::new(OPT_TARGET_DIRECTORY)
.short('t')
.long(OPT_TARGET_DIRECTORY)
Expand Down Expand Up @@ -732,12 +730,9 @@ fn perform_backup(to: &Path, b: &Behavior) -> UResult<Option<PathBuf>> {
}
let backup_path = backup_control::get_backup_path(b.backup_mode, to, &b.suffix);
if let Some(ref backup_path) = backup_path {
// TODO!!
if let Err(err) = fs::rename(to, backup_path) {
return Err(
InstallError::BackupFailed(to.to_path_buf(), backup_path.clone(), err).into(),
);
}
fs::rename(to, backup_path).map_err(|err| {
InstallError::BackupFailed(to.to_path_buf(), backup_path.clone(), err)
})?;
}
Ok(backup_path)
} else {
Expand Down
Loading