Skip to content

chroot: make group option self overwriting #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
Jan 12, 2025
Merged

chroot: make group option self overwriting #7123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/uu/chroot/src/chroot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ pub fn uu_app() -> Command {
.arg(
Arg::new(options::GROUPS)
.long(options::GROUPS)
.overrides_with(options::GROUPS)
.help("Comma-separated list of groups to switch to")
.value_name("GROUP1,GROUP2..."),
)
Expand Down
16 changes: 16 additions & 0 deletions tests/by-util/test_chroot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,22 @@ fn test_no_such_directory() {
.code_is(125);
}

#[test]
fn test_multiple_group_args() {
let ts = TestScenario::new(util_name!());
let at = &ts.fixtures;
at.mkdir("id");

if let Ok(result) = run_ucmd_as_root(
&ts,
&["--groups='invalid ignored'", "--groups=''", "/", "id", "-G"],
) {
result.success().stdout_is("0");
} else {
print!("Test skipped; requires root user");
}
}

#[test]
fn test_invalid_user_spec() {
let ts = TestScenario::new(util_name!());
Expand Down
Loading