rm: Remove remove_dir_all dependency #4340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
force-pushed
the
remove_dir_all
branch
from
43a4167 to
c6f212d
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Member
There was a problem hiding this comment.
Okay so I may have jumped the gun by creating an issue for it. Looking into this some more, there's still this open issue: rust-lang/rust#29497. But I'm not really sure how big of an issue that is and there have also been a lot of improvements over the years. Ideally we'd have some test case for it.
@sylvestre do you think we should try this?
deny.toml
Outdated
| # introduces it. | ||
| # spell-checker: disable | ||
| skip = [ | ||
| # tempfile |
Member
There was a problem hiding this comment.
Could you remove this line as well?
howjmay
force-pushed
the
remove_dir_all
branch
from
c6f212d to
0b1edd3
Compare
Contributor
|
At least, the CI is green here :) |
Member
|
Alright, we'll see how it goes, we can always revert :) Thanks @howjmay! |
Contributor
Author
|
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4335