Document supported versions and test minimum #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcterus
requested changes
Dec 5, 2017
README.md
Outdated
| Rust Version | ||
| ------------ | ||
|
|
||
| coreutils supports and is tested on version `1.20.0` and above (including beta and nightly builds) of `rustc`. |
There was a problem hiding this comment.
coreutils should probably be changed to uutils to keep consistent with the rest of the README.
There was a problem hiding this comment.
Changed.
Should the same be done here? https://github.com/uutils/coreutils#contribute
There was a problem hiding this comment.
Ah, I never noticed that. Yes, please change that one as well.
skade
force-pushed
the
document-base-version
branch
from
cb6d268 to
89cb6f1
Compare
|
On Windows: that probably makes sense, but can be done at a later point. Does it make sense to indicate that in the README? |
|
I think so, as currently there are no guarantees that the code works for Windows on stable unless you test it yourself. |
skade
force-pushed
the
document-base-version
branch
from
89cb6f1 to
04e9537
Compare
|
Amended the README to include that info. |
Arcterus
approved these changes
Dec 5, 2017
|
Thanks, hopefully this will help people get started with the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1100