support SuppressWarning annotation

uumailbox · Aug 19, 2020 · 87ba608 · 87ba608
1 parent 54bbd46
commit 87ba608
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 16 deletions.
diff --git a/idea-plugin/p3c-common/src/main/kotlin/com/alibaba/p3c/idea/inspection/AliPmdInspection.kt b/idea-plugin/p3c-common/src/main/kotlin/com/alibaba/p3c/idea/inspection/AliPmdInspection.kt
@@ -32,10 +32,9 @@ import org.jetbrains.annotations.Nls
  * @author caikang
  * @date 2016/12/16
  */
-class AliPmdInspection(private val ruleName: String)
-    : LocalInspectionTool(),
-        AliBaseInspection,
-        PmdRuleInspectionIdentify {
+class AliPmdInspection(private val ruleName: String) : LocalInspectionTool(),
+    AliBaseInspection,
+    PmdRuleInspectionIdentify {
     override fun manualBuildFix(psiElement: PsiElement, isOnTheFly: Boolean): LocalQuickFix? {
         return QuickFixes.getQuickFix(ruleName, isOnTheFly)
     }
@@ -62,8 +61,10 @@ class AliPmdInspection(private val ruleName: String)
         return true
     }
 
-    override fun checkFile(file: PsiFile, manager: InspectionManager,
-            isOnTheFly: Boolean): Array<ProblemDescriptor>? {
+    override fun checkFile(
+        file: PsiFile, manager: InspectionManager,
+        isOnTheFly: Boolean
+    ): Array<ProblemDescriptor>? {
         if (!shouldInspectChecker.shouldInspect(file)) {
             return null
         }
@@ -96,10 +97,6 @@ class AliPmdInspection(private val ruleName: String)
         return true
     }
 
-    override fun isSuppressedFor(element: PsiElement): Boolean {
-        return false
-    }
-
     override fun getShortName(): String {
 
         var shortName = "Alibaba" + ruleName

diff --git a/...p3c-common/src/main/kotlin/com/alibaba/p3c/idea/inspection/DelegateLocalInspectionTool.kt b/...p3c-common/src/main/kotlin/com/alibaba/p3c/idea/inspection/DelegateLocalInspectionTool.kt
@@ -45,8 +45,10 @@ class DelegateLocalInspectionTool : LocalInspectionTool(), AliBaseInspection {
         return localInspectionTool.runForWholeFile()
     }
 
-    override fun checkFile(file: PsiFile, manager: InspectionManager,
-            isOnTheFly: Boolean): Array<ProblemDescriptor>? {
+    override fun checkFile(
+        file: PsiFile, manager: InspectionManager,
+        isOnTheFly: Boolean
+    ): Array<ProblemDescriptor>? {
         return localInspectionTool.checkFile(file, manager, isOnTheFly)
     }
 
@@ -81,11 +83,13 @@ class DelegateLocalInspectionTool : LocalInspectionTool(), AliBaseInspection {
     }
 
     override fun isSuppressedFor(element: PsiElement): Boolean {
-        return false
+        return localInspectionTool.isSuppressedFor(element)
     }
 
-    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean,
-            session: LocalInspectionToolSession): PsiElementVisitor {
+    override fun buildVisitor(
+        holder: ProblemsHolder, isOnTheFly: Boolean,
+        session: LocalInspectionToolSession
+    ): PsiElementVisitor {
         if (!AliLocalInspectionToolProvider.javaShouldInspectChecker.shouldInspect(holder.file)) {
             return PsiElementVisitor.EMPTY_VISITOR
         }

diff --git a/...lugin/p3c-common/src/main/kotlin/com/alibaba/p3c/idea/inspection/DelegatePmdInspection.kt b/...lugin/p3c-common/src/main/kotlin/com/alibaba/p3c/idea/inspection/DelegatePmdInspection.kt
@@ -78,6 +78,6 @@ class DelegatePmdInspection : LocalInspectionTool(), AliBaseInspection, PmdRuleI
     }
 
     override fun isSuppressedFor(element: PsiElement): Boolean {
-        return false
+        return aliPmdInspection.isSuppressedFor(element)
     }
 }