June '19 update #306
Merged
June '19 update #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| tag-version-prefix="v" | |||
| save-prefix="~" | |||
There was a problem hiding this comment.
would suggest exact versions rather than any floating version - but your call
There was a problem hiding this comment.
package.jsonalready specifies the exact versions, and is whatnpm installprefers (I believe).- I actually see exact versions in package.json as an anti-pattern, as it makes it redundant with
package-lock.json, while nullifying any value to be had from thenpm outdatedandnpm upgradecommands.
|
@defunctzombie Updated to address recent github audit warnings. Approve, please. |
| "mocha": "5.2.0", | ||
| "runmd": "1.0.1", | ||
| "standard-version": "4.4.0" | ||
| "@commitlint/cli": "7", |
There was a problem hiding this comment.
Personally not a fan of this style of dependency tracking (for same reasons as mentioned earlier in this PR).
defunctzombie
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vulnerability warnings.
Keeps README from changing every time it's generated
Remove node v4 from travis (
mochano longer supports v4)