-
-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
June '19 update #306
June '19 update #306
Conversation
@@ -0,0 +1,2 @@ | |||
tag-version-prefix="v" | |||
save-prefix="~" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would suggest exact versions rather than any floating version - but your call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
already specifies the exact versions, and is whatnpm install
prefers (I believe).- I actually see exact versions in package.json as an anti-pattern, as it makes it redundant with
package-lock.json
, while nullifying any value to be had from thenpm outdated
andnpm upgrade
commands.
@defunctzombie Updated to address recent github audit warnings. Approve, please. |
"mocha": "5.2.0", | ||
"runmd": "1.0.1", | ||
"standard-version": "4.4.0" | ||
"@commitlint/cli": "7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally not a fan of this style of dependency tracking (for same reasons as mentioned earlier in this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of the dependency specifications and think we could probably do away with the README_js generation - seems fine otherwise.
Fixes vulnerability warnings.
Keeps README from changing every time it's generated
Remove node v4 from travis (
mocha
no longer supports v4)