Implement deserialize for format uuid types #832
Conversation
|
@KodrAus hey, this has been lying around a bit- could someone of the team have a look? It's not much. |
| where | ||
| D: serde::Deserializer<'de>, | ||
| { | ||
| Ok(Uuid::deserialize(deserializer)?.into()) |
There was a problem hiding this comment.
If you're trying to deserialize a UUID into one of these proxy types, I think we should only accept a UUID in its format. We should be able to make the visitor used in Uuid's deserialize impl generic and add appropriate FromStr implementations to the proxy types. Then the bound on that visitor would be any T: FromStr + From<Uuid>.
I'd be happy to sketch it out a bit further if that would be helpful 🙂
There was a problem hiding this comment.
I don't really understand what your goal is. The proxy types are just formatting wrappers that each just simply hold a Uuid in a Unit struct. Anything that is a Uuid can be wrapped in these proxy types.
You mean, that if you wish to deserialise a Hyphenated, the input may only be a hyphenated?
If yes, I think I get what you mean.
There was a problem hiding this comment.
@Kek5chen That’s right; I think deserlializing a hyphenated UUID should only succeed on a hyphenated input.
There was a problem hiding this comment.
Alright, I can change it to have that behavior
Finished the work stated in #534 and only partially implemented in #546 .
Implemented deserialize for format types
Refactors serialize statements into a macro call for brevity.