make ClockSequence wrap correctly #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
approved these changes
Aug 11, 2023
|
It looks like we've got some tests for this function afterall. This one is now failing: |
|
Ah, I missed that one because I forgot to enable the feature while testing. Sorry! It's just a matter of changing the counter's initializer to the correct value though, I'll fix it soon. |
Fixes issue uuid-rs#702
|
Thanks for fixing this up @fef1312! I should probably move those tests to live with the type itself. I was surprised not to see any for it, and didn't realise that they were just way off in a different module. |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Oct 19, 2023
Bumps uuid from 1.4.1 to 1.5.0. Release notes Sourced from uuid's releases. 1.5.0 What's Changed Add impl From for String under the std feature flag by @brahms116 in uuid-rs/uuid#700 Remove dead link to templates by @KodrAus in uuid-rs/uuid#704 make ClockSequence wrap correctly by @fef1312 in uuid-rs/uuid#705 Track MSRV in Cargo.toml by @KodrAus in uuid-rs/uuid#706 Support converting between Uuid and vec by @KodrAus in uuid-rs/uuid#703 Replace MIPS with Miri and add clippy to CI by @KodrAus in uuid-rs/uuid#712 Added bytemuck support by @John-Toohey in uuid-rs/uuid#711 Prepare for 1.5.0 release by @KodrAus in uuid-rs/uuid#713 New Contributors @brahms116 made their first contribution in uuid-rs/uuid#700 @fef1312 made their first contribution in uuid-rs/uuid#705 @John-Toohey made their first contribution in uuid-rs/uuid#711 Full Changelog: uuid-rs/uuid@1.4.1...1.5.0 Commits e68b010 Merge pull request #713 from uuid-rs/cargo/1.5.0 b1cc27a prepare for 1.5.0 release b8ebdee Merge pull request #711 from John-Toohey/bytemuck 2dad70d Added the bytemuck optional dependency to lib.rs documentation bcf2b58 Added Bytemuck to .github/workflows/ci.yml::env::DEP_FEATURES a8d2e1d Merge pull request #712 from uuid-rs/ci/miri-clippy 0c5b2df fix up a clippy warning 1d4bd6e Merge pull request #703 from uuid-rs/feat/convert-to-vec 52b3fbc replace MIPS with Miri and add clippy to CI 3833d09 Make the bytemuck dependency look more like the other dependencies Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in the original issue, the implementation of
ClockSequenceforContextincorrectly wrapped after0x3ffeinstead of0x3fff. Fixes #702.