-
Notifications
You must be signed in to change notification settings - Fork 52
3.x #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
3.x #759
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7e3656b
added support for object type attribute
ArnabChatterjee20k 6edfe1a
updated validators
ArnabChatterjee20k 4483496
updated tests
ArnabChatterjee20k 10cf2bd
* added gin index
ArnabChatterjee20k 8cd5921
removed redundant return after skip in tests
ArnabChatterjee20k 117af69
updated array handling for equal and contains in object
ArnabChatterjee20k a92fd41
Merge remote-tracking branch 'upstream/main' into var_object
ArnabChatterjee20k 979619f
fixed gin index issue
ArnabChatterjee20k 6ba8558
updated validating default types
ArnabChatterjee20k 49139d8
Merge remote-tracking branch 'upstream/main' into var_object
ArnabChatterjee20k 739a4c3
* added support method in the mongodb adapter
ArnabChatterjee20k 2cb3d98
renamed gin to object index to have a general term
ArnabChatterjee20k e2768d9
updated lock file
ArnabChatterjee20k f62ff51
Merge remote-tracking branch 'upstream/main' into var_object
ArnabChatterjee20k f5c0cfd
Refactor object type constants to use VAR_OBJECT for consistency acro…
ArnabChatterjee20k 9a96110
added object validator test
ArnabChatterjee20k fd74c74
Merge remote-tracking branch 'upstream/3.x' into var_object
ArnabChatterjee20k 8649aca
update var_object to be a filter similar to other types
ArnabChatterjee20k cd4e0b5
linting
ArnabChatterjee20k 80b742e
Merge branch 'fix/vector-queries' into var_object
ArnabChatterjee20k 9a0cea6
added test to simulate a vector store
ArnabChatterjee20k fad8570
removed reduntant comment
ArnabChatterjee20k 29f4cfe
updated the semantics for not equal case
ArnabChatterjee20k 5b34785
index, attribute filters, typo updates
ArnabChatterjee20k 9a01de3
linting
ArnabChatterjee20k 8062cfc
Merge pull request #741 from utopia-php/var_object
abnegate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix nested array containment support.
Try inserting a document with
meta.profile.skills = ['php', 'go']and runningQuery::contains('meta', [['profile' => ['skills' => 'php']]]). The SQL we emit becomesmeta @> '{"profile":{"skills":"php"}}'::jsonb, which PostgreSQL will never match because"skills"is stored as an array, not a scalar. The helper only wraps scalars when the fragment consists of a single top-level key, so any nested array (and even top-level arrays combined with other keys) silently stops matching. As a resultcontains()can no longer express “profile.skills contains X”, which is a correctness regression for realistic payloads. Please normalize these fragments recursively (or drop the partial scalar-to-array heuristic and require callers to supply the proper JSON shape) so nested array lookups continue to work. Happy to help iterate on the fix.🤖 Prompt for AI Agents