-
Notifications
You must be signed in to change notification settings - Fork 52
Documentsdb(Schemaless support with mongodb adapter) #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds MongoDB support across infrastructure, dependencies, and tests. Expands adapter interfaces for capabilities and casting hooks, updates SQL/Pool adapters, and revises Database control flow to use instance query conversion and pre/post casting. Validators gain attribute-support flags and dynamic limits. Tests updated/added for MongoDB, shared tables, schemaless, and UUID7 handling. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor T as Test/Client
participant DB as Database
participant V as Validators
participant A as Adapter (SQL/Mongo/Pool)
T->>DB: create/find/update/delete(...)
DB->>V: init validators (supportForAttributes, index flags, max UID)
V-->>DB: validation result
rect rgb(235, 245, 255)
note right of DB: Pre-processing
DB->>A: castingBefore(collection, document)
A-->>DB: pre-cast document
end
DB->>A: execute operation (queries now instance-based)
A-->>DB: raw result(s)
rect rgb(235, 255, 235)
note right of DB: Post-processing
DB->>A: castingAfter(collection, document)
A-->>DB: post-cast document
end
DB-->>T: response
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60–90 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bcd8148 to
ff4c8af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultipleFulltextIndex should get the first priority in case of mongodb especially when supportForAttributes is true and we have multiple full text indexes like here
Summary by CodeRabbit
New Features
Chores
Tests