cursor before logic

[fogelito]

Summary by CodeRabbit

• Refactor

  • Simplified pagination and ordering logic for database queries by removing cursor direction handling.
  • Improved consistency in how order types are set and managed during paginated searches.

• Bug Fixes

  • Enhanced error checking for cursor-based pagination to ensure all order attributes have valid values.

End-users may notice more predictable and streamlined behavior when using paginated database queries. No changes to the overall interface or functionality are required on your part.

[coderabbitai]

Walkthrough

The changes remove the $cursorDirection parameter from the find method across the Adapter, MariaDB, Postgres, and Pool classes, along with all related logic for handling cursor direction in pagination. The Database class now handles cursor direction internally, inverting order types and reversing results as needed, without passing this parameter to adapters.

Changes

File(s)	Change Summary
src/Database/Adapter.php	Removed $cursorDirection from find method signature and updated PHPDoc.
src/Database/Adapter/MariaDB.php src/Database/Adapter/Postgres.php	Removed $cursorDirection from find method signature and eliminated all related logic.
src/Database/Adapter/Pool.php	Removed $cursorDirection from find method signature; updated parameter order and default values.
src/Database/Database.php	Moved cursor direction handling inside find; now inverts order types and reverses results internally.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Database
    participant Adapter (MariaDB/Postgres/Pool)

    Client->>Database: find(collection, queries, ..., cursor, cursorDirection)
    Database->>Database: Adjust orderTypes if cursorDirection == BEFORE
    Database->>Adapter (MariaDB/Postgres/Pool): find(collection, queries, ..., cursor, forPermission)
    Adapter (MariaDB/Postgres/Pool)-->>Database: results
    Database->>Database: Reverse results if cursorDirection == BEFORE
    Database-->>Client: results

Loading

Estimated code review effort

2 (~20 minutes)

Suggested reviewers

• abnegate

Poem

In the warren of code, the cursors would roam,
But now their direction is handled at home.
No more confusion, no flipping in flight—
The adapters are lighter, the queries more right.
With paws on the order and ears to the ground,
This bunny declares: cleaner code all around! 🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85b7ff6 and 95f7952.

📒 Files selected for processing (5)

• src/Database/Adapter.php (1 hunks)
• src/Database/Adapter/MariaDB.php (2 hunks)
• src/Database/Adapter/Pool.php (1 hunks)
• src/Database/Adapter/Postgres.php (2 hunks)
• src/Database/Database.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

• src/Database/Adapter/Pool.php
• src/Database/Adapter.php
• src/Database/Adapter/MariaDB.php
• src/Database/Adapter/Postgres.php
• src/Database/Database.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Setup & Build Docker Image

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.