feat: add ScyllaDB adapter support #523
Conversation
- Add ScyllaDB adapter class with full database operations support - Add comprehensive test suite for ScyllaDB adapter - Add ScyllaDB services to docker-compose.yml - Update README with ScyllaDB connection example and specs
| return true; | ||
| } | ||
|
|
||
| $sql = "CREATE KEYSPACE {$name} WITH replication = {'class': 'SimpleStrategy', 'replication_factor': 3}"; |
There was a problem hiding this comment.
I think that we should set the replication factor to 1 since by default we will not have a cluster?
Or maybe set some kind of env variable to customise it and the strategy
There was a problem hiding this comment.
Good point! The replication factor is set to 3 as a default for fault tolerance in case we scale to a cluster later. But you’re right if we’re not running a cluster yet, 1 makes more sense for now.
| */ | ||
| public function getSupportForFulltextIndex(): bool | ||
| { | ||
| return false; // ScyllaDB doesn't support fulltext search natively |
There was a problem hiding this comment.
Maybe we can use materialized view alternatively?
|
amazing job @tinkerer-shubh! 🔥 |
tinkerer-shubh
force-pushed
the
feat-scylladb-adapter
branch
from
10c19e1 to
c968c7f
Compare
Thank you! This is far from perfect though. The initial goal was to achieve an MVP of sorts and then iterate further based on the feedback. I see the checks are failing too, will take a look. :) I was also thinking that maybe it's best to mark this as a draft for now while it's still in its iteration phase? |
|
nice one @tinkerer-shubh |
5 participants
Add ScyllaDB Adapter Support
related issue : #9295
This PR adds initial support for ScyllaDB as a new database adapter in the Utopia Database library.
Features
The ScyllaDB adapter implements core database operations:
Implementation Details
Testing
tests/e2e/Adapter/ScyllaDBTest.phpdocker-compose up scylladbDocumentation
Added to README:
Specifications